Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MulticastVM per (vmInstanceId / GroupName) #248

Closed
treg opened this issue May 22, 2020 · 3 comments
Closed

MulticastVM per (vmInstanceId / GroupName) #248

treg opened this issue May 22, 2020 · 3 comments

Comments

@treg
Copy link

treg commented May 22, 2020

I would have expected VMFactory.GetMulticastInstance to return/create a MulticastVM per vmInstanceId, just like BaseVM

However the key in GetMulticastInstance is only looking for vmType.FullName not vmType.FullName + '$' + vmInstanceId, like BaseVM

Is this behavior intended or is it a bug?

Also:

I have set MulticastVM.GroupName => vmInstanceId
Still returns the MulticastVM instance not a MulticastVM.GroupName instance

@treg treg changed the title MulticastVM per vmInstanceId MulticastVM per (vmInstanceId / GroupName) May 22, 2020
@dsuryd
Copy link
Owner

dsuryd commented May 25, 2020

It seems to be an oversight; will investigate further when I have the chance. What use case do you have for this?

@treg
Copy link
Author

treg commented May 25, 2020 via email

@dsuryd
Copy link
Owner

dsuryd commented Jun 1, 2020

Fix is published in the latest.

@dsuryd dsuryd closed this as completed Jun 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants