-
Notifications
You must be signed in to change notification settings - Fork 164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MulticastVM per (vmInstanceId / GroupName) #248
Comments
treg
changed the title
MulticastVM per vmInstanceId
MulticastVM per (vmInstanceId / GroupName)
May 22, 2020
It seems to be an oversight; will investigate further when I have the chance. What use case do you have for this? |
The use case is multiple simultaneous editors of a single instance of an
online form.
Where the vmInstance is the form instance id.
…On Mon, May 25, 2020, 5:43 PM Dicky Suryadi ***@***.***> wrote:
It seems to be an oversight; will investigate further when I have the
chance. What use case do you have for this?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#248 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAF4Y3FUJYPTV2GITYTGXL3RTLYCXANCNFSM4NH7ZHXQ>
.
|
dsuryd
pushed a commit
that referenced
this issue
May 27, 2020
Fix is published in the latest. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I would have expected VMFactory.GetMulticastInstance to return/create a MulticastVM per vmInstanceId, just like BaseVM
However the key in GetMulticastInstance is only looking for vmType.FullName not vmType.FullName + '$' + vmInstanceId, like BaseVM
Is this behavior intended or is it a bug?
Also:
I have set MulticastVM.GroupName => vmInstanceId
Still returns the MulticastVM instance not a MulticastVM.GroupName instance
The text was updated successfully, but these errors were encountered: