Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade from 3.6.2 to 3.7.0 - Redirecting to 404.html #246

Closed
treg opened this issue May 18, 2020 · 4 comments
Closed

Upgrade from 3.6.2 to 3.7.0 - Redirecting to 404.html #246

treg opened this issue May 18, 2020 · 4 comments

Comments

@treg
Copy link

treg commented May 18, 2020

We have been using DotNetify since 3.3.1.
Without changing any of our code and after upgrading from 3.6.2 to 3.7.0, dotNetify will auto redirect to 404.html.
However, If I add "dotnetify.react.router.urlPath = null;" before calling connect, everything works as before.

I believe the issue is in dotnetify-vm-router.ts line # 88

Please assist.....

-- our pre-connect setup --

import dotnetify from 'dotnetify';
dotnetify.hubServerUrl = document.location.origin + '/' + document.location.pathname.split('/')[1];;
dotnetify.debug = (!process.env.NODE_ENV || process.env.NODE_ENV === 'development');

//added to prevent auto redirect to 404.html
dotnetify.react.router.urlPath = null;

@treg treg changed the title Upgrade from 3.6.2 to 3.7.0 - Router Auto Redirecting to 404.html Upgrade from 3.6.2 to 3.7.0 - Redirecting to 404.html May 18, 2020
@dsuryd
Copy link
Owner

dsuryd commented May 18, 2020

I just published 3.7.1 to correct the faulty logic. Let me know whether it fixes the issue.

@treg
Copy link
Author

treg commented May 18, 2020

upgraded to 3.7.1; it works almost :)
still see "router> routed (404)" in the browser debugger window.
but it does not route

@dsuryd
Copy link
Owner

dsuryd commented May 18, 2020

It's an expected debug message. The wording may change in the future since it's misleading if you're not using dotNetify routing, but shouldn't be a problem for closing this issue. Thanks!

@dsuryd dsuryd closed this as completed May 18, 2020
@treg
Copy link
Author

treg commented May 18, 2020 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants