Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue with Customized with Json serializations configuration #195

Closed
mason-chase opened this issue Jun 30, 2019 · 2 comments
Closed

Issue with Customized with Json serializations configuration #195

mason-chase opened this issue Jun 30, 2019 · 2 comments

Comments

@mason-chase
Copy link
Contributor

Hi,

UseJsonSerializerSettings currently doesn't allow access to original VMSerializer.SerializerSettings value to avoid serializing Action and ICommand properties.

To VMContractResolver to work properly I have added additional methods to give us better direct access to instantiate Dotnetify's Json converter.

Regards
Mason
@mason-chase mason-chase mentioned this issue Jun 30, 2019
Closed
@mason-chase
Copy link
Contributor Author

Apparently there are existing code in the project that doesn't meet the standard, should I make further changes on other areas to suppress the code standard error?

@dsuryd
Copy link
Owner

dsuryd commented Jun 30, 2019

Looks good. The failing standard check looks to be false positive, can be ignored.
Could you add the unit test in DotNetifyConfigurationTest.cs?

@mason-chase mason-chase mentioned this issue Jul 3, 2019
Closed
dsuryd added a commit that referenced this issue Jul 8, 2019
@dsuryd
Merge pull request #198 from mason-chase/master
b656e83 
#195 Add method to configure VMSerializer.SerializerSettings
@dsuryd dsuryd closed this as completed Jul 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dsuryd @mason-chase