Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

initial_type refactoring #29

Open
jesteria opened this issue May 21, 2020 · 1 comment
Open

initial_type refactoring #29

jesteria opened this issue May 21, 2020 · 1 comment

Comments

@jesteria
Copy link
Member

jesteria commented May 21, 2020

The existing use of User.initial_type suggests some reconsideration.

  • A value of DSSG_STAFF dictates whether a user can use the custom admin page, (to approve volunteer profiles – but nothing else)
  • …While a value of ORGANIZATION dictates whether a user can perform some organizational functions
  • Users are given DSSG_STAFF only when created by developer CLI
  • …And either ORGANIZATION or VOLUNTEER during registration
  • Users should likely be given the opportunity to perform these functions regardless of how they were created/registered.
  • It is slightly odd that users have an "initial type" which dictates later permissions (and no further "type").

Documentation

Originally posted by @jesteria in #27 (comment)

@jesteria
Copy link
Member Author

It seems possible that the app could do without initial_type entirely. This may be slightly inconvenient to the registration workflow, (but likely resolvable). User permissions and workflows following registration/creation should then be dependent upon other values.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant