-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Small fixes #56
base: master
Are you sure you want to change the base?
Small fixes #56
Conversation
Thanks! We still seem to have some failing tests. Can you please look into it? BTW In the future we'd like to have the tests be less brittle. |
I 've spent some time trying to figure it out, but I haven't marked any progress yet because I can't seem to reproduce the failure: the tests succeed on all the setups I 've tried and unfortunately travis' log indicates a crash, but no relevant output (just an exit with a non-zero return code when running UmlGraphDoc). I 'd be grateful if you could test it as well since I might be missing something here. Thank you for your time! |
Sadly, I can't test it locally, until we resolve #57. |
The majority is just about typos / formatting / rough edges.
Commit 0a71dbf undoes part of what 477d5cc introduced, where UmlDocTest would exit (successfully) before comparing the doclet output to the reference. This unfortunately masked some failing tests (e.g.
testdata/umldoc-ref/gr/spinellis/invoice/gr.spinellis.invoice.dot
), where a class relation multiplicity does not appear. These tests now fail.