Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can you tag with a Go Modules compatible version tag? #62

Closed
bep opened this issue Jul 15, 2021 · 8 comments
Closed

Can you tag with a Go Modules compatible version tag? #62

bep opened this issue Jul 15, 2021 · 8 comments

Comments

@bep
Copy link

bep commented Jul 15, 2021

Seems like Go Modules is very picky about version format, it recognizes v3.0.0, but not 3.0.0.

@dsoprea
Copy link
Owner

dsoprea commented Jul 17, 2021

Valid point, though I feel like it might be more appropriate to do a major bump to v4.0.0 as an unrecognized/opaque version could be comparatively no different than a backwards-incompatible one. Thoughts?

@dsoprea
Copy link
Owner

dsoprea commented Jul 17, 2021

I'm currently traveling, so my responses can be delayed and I'll likely take no action in the next week.

@bep
Copy link
Author

bep commented Jul 17, 2021

Thoughts?

A major bump would require a new "path update" (/v4), or whatever Go Modules calls it ... I would have just duplicated the tag, as both would point to the same Git ref (version). But that does not matter too much to me, as long as Go Modules are happy.

Also, no rush.

A little digression, but you have a little unusual project structure vs major versions. I suspect it would be easier to navigate and maintain if you just kept all versions in the root and just incremented in go.mod (and possibly also created a new default branch), but up to you.

@bep
Copy link
Author

bep commented Aug 31, 2021

Bump; could you also have a look at #63 ... which is a blocker for pulling this library into Hugo. Thanks!

@dsoprea
Copy link
Owner

dsoprea commented Sep 5, 2021

Sure. I'll do it in the next couple of days. Sorry for the delay. This feel off my radar. Plus, it won't be enough to update this project, but also the constellation of tools and format-specific integrations that I've written against it, which will then affect even more people. I'll likely put a note in each project's README out of an abundance of caution.

@marang
Copy link

marang commented Jan 24, 2022

hey, looking forward to have working exif lib in hugo soon.

@dsoprea
Copy link
Owner

dsoprea commented Apr 22, 2023

Done. Pushed v3.0.1 .

@dsoprea dsoprea closed this as completed Apr 22, 2023
@dsoprea
Copy link
Owner

dsoprea commented Apr 22, 2023

@bep We'll consider this (collapsing the current release-oriented paths) if we ever release v4.

#62 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants