Fixes leaking Redis subscriptions for socketio#663. The local flag wa…

…s not getting passed through onClientDisconnect().
dshaw · Nov 26, 2011 · d5ab46d · d5ab46d
1 parent eeaca6d
commit d5ab46d
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 4 deletions.
diff --git a/lib/manager.js b/lib/manager.js
@@ -468,13 +468,13 @@ Manager.prototype.onClientMessage = function (id, packet) {
  * @api private
  */
 
-Manager.prototype.onClientDisconnect = function (id, reason) {
+Manager.prototype.onClientDisconnect = function (id, reason, local) {
   for (var name in this.namespaces) {
     this.namespaces[name].handleDisconnect(id, reason, typeof this.roomClients[id] !== 'undefined' &&
       typeof this.roomClients[id][name] !== 'undefined');
   }
 
-  this.onDisconnect(id);
+  this.onDisconnect(id, local);
 };
 
 /**

diff --git a/lib/transport.js b/lib/transport.js
@@ -457,14 +457,15 @@ Transport.prototype.end = function (reason) {
   if (!this.disconnected) {
     this.log.info('transport end');
 
-    var local = this.manager.transports[this.id];
+    var local = !!this.manager.transports[this.id];
 
     this.close();
     this.clearTimeouts();
     this.disconnected = true;
 
+
     if (local) {
-      this.manager.onClientDisconnect(this.id, reason, true);
+      this.manager.onClientDisconnect(this.id, reason, local);
     } else {
       this.store.publish('disconnect:' + this.id, reason);
     }