Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ansible 7 compatibility fixes #15

Merged
merged 10 commits into from
Dec 31, 2022
Merged

Ansible 7 compatibility fixes #15

merged 10 commits into from
Dec 31, 2022

Conversation

dseeley
Copy link
Owner

@dseeley dseeley commented Dec 5, 2022 •
edited
Loading

  • Move from ec2 to amazon.aws.ec2_instance module.
    • volumes structure changed; maintain old syntax in cluster_defs.
    • Spot instances no longer supported.
  • ec2_instance returns success when instances are also in pending, so also check this.
  • Fix for route53 rescue.
  • Use older name of instance_role instead of iam_instance_profile for ec2_instance, as it is backwards compatible.
  • Update minimum Ansible version to 5.6.0; update assertions.
  • Enable selecting Ansible version in Jenkinsfile_testsuite and Jenkinsfile_ops
    • Jenkinsfile_testsuite: remove findAll(), which can't escape the sandbox
  • Revert to community versions of libvirt where possible
  • Add retries to libvirt pool refresh (in case of concurrent background operations)

Dougal Seeley added 8 commits December 5, 2022 08:14
Ansible 7 compatibility fixes.
f5154d8 
+ Move ec2 to amazon.aws.ec2_instance.  Spot instances not supported.
Update the volumes structure for amazon.aws.ec2_instance
81e2756
Fixes:
512307c 
+ Fix for route53 rescue.
+ New ec2_instance returns success when instances are also in `pending, so also check this.
+ Use older name of `instance_role` instead of `iam_instance_profile` for ec2_instance, as it is backwards compatible.
debug ec2_instance_info
5bdb2c5
add state to the ec2_instance filter
331d611
remove temporary debug
f53c149
Increase IOPS size for gp3 disks to 3000 (minimum)
844c69c
Return value from ec2_instance does not contain the instance info if …
cdeae6d 
…the VM already exists; must acquire cluster_hosts_state immediately afterwards.

Set ec2_instance `state` to `running`, so that it only returns when the VM is in running state, not pending (needed in case of applying static IP addresses)
Update minimum Ansible version to 5.6.0; update assertions.
9039cac 
Enable selecting Ansible version in Jenkinsfile_testsuite and Jenkinsfile_ops
Revert to community versions of libvirt where possible
@dseeley dseeley force-pushed the ansible7 branch 2 times, most recently from e9f0cb8 to 3ff1604 Compare December 31, 2022 05:53
Add retries to libvirt pool refresh (in case of concurrent background…
f200b67 
… operations)

Jenkinsfile_testsuite: Set sandbox true for active choice parameter; remove findAll which can't escape the sandbox
@dseeley dseeley merged commit e832c5f into master Dec 31, 2022
@dseeley dseeley deleted the ansible7 branch December 31, 2022 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@dseeley