Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds SharedPreferences service #180

Merged
merged 2 commits into from
Dec 22, 2020
Merged

Adds SharedPreferences service #180

merged 2 commits into from
Dec 22, 2020

Conversation

haru-02
Copy link
Contributor

@haru-02 haru-02 commented Dec 18, 2020 •
edited by Thesmader
Loading

Created a service for SharedPreferences with a method to return a single instance of SharedPreferences.

@haru-02
added localStorage_service.dart under services.
23dc63e 
i followed the reference as given and made a function that returns an instance. please let me know if there are any changes to be made.
@github-actions
Copy link

image image
Hello @haru-02 , That's a great improvement to the code. Have a pinch of paitence while the reviewer gets impressed by the changes you made. Here are some doggos for company while you are waiting for the merge and marching ahead with your Hacktoberfest Contributions, Check your Dashboard for more information on Hacktoberfest. Stay safe 🚀 .

@github-actions
Copy link

image image
Hello @haru-02 , That's a great improvement to the code. Have a pinch of paitence while the reviewer gets impressed by the changes you made. Here are some doggos for company while you are waiting for the merge and marching ahead with your Hacktoberfest Contributions, Check your Dashboard for more information on Hacktoberfest. Stay safe 🚀 .

@Thesmader Thesmader changed the title added localStorage_service.dart under services. Adds SharedPreferences service Dec 21, 2020
@Thesmader Thesmader linked an issue Dec 21, 2020 that may be closed by this pull request
[WoC] Services - Create a SharedPreferences service #177
Closed
@Chinmay-KB Chinmay-KB merged commit 9ff458c into dscnitrourkela:refactor Dec 22, 2020
@haru-02 haru-02 deleted the shared_preferences branch December 22, 2020 17:32
DesignrKnight pushed a commit that referenced this pull request Dec 28, 2020
@Chinmay-KB
Merge pull request #180 from haru-02/shared_preferences
e803908 
Adds SharedPreferences service

Former-commit-id: 9ff458c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Thesmader Thesmader Thesmader left review comments

@Chinmay-KB Chinmay-KB Chinmay-KB approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[WoC] Services - Create a SharedPreferences service
3 participants
@haru-02 @Chinmay-KB @Thesmader