-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Combine TimeZoneDsc Resource with ComputerManagementDsc #33
Comments
I agree that they would fit better in ComputerManagementDsc. than have only one resource in a resource module. If the resource would have been called WindowsTimeDsc, then it could have been extended with more functionality for handling Windows Time Service. But even so, it would be better to have that in ComputerManagementDsc. |
This is now in progress. I'll move it to HQRM at the same time (well I have to 😁 ) |
We should update this resource module with a deprecated message once PR dsccommunity/ComputerManagementDsc#158 is merged. See example here: |
I think we should also update Maintainers.md in DscResources that instead of a maintainer it says 'DEPRECATED - moved to ComputerManagementDsc' or similar. 🤔 |
Good idea - I'll get a PR ready to submit for it. I'm going to work on xPendingReboot next. |
As we are going to be changing this resource over to TimeZoneDsc in the near future it might make sense to move it over to make it part of ComputerManagementDsc during the move. I would also suggest doing the same with SystemLocaleDsc.
@kwirkykat - do you have any thoughts on this? I'm happy to keep them separate but I thought it might simplify things as these "individual" resources make more sense together.
And if we're implementing the fairly destructive changes of renaming the modules to *Dsc, this would seem to be the best time to do it.
The text was updated successfully, but these errors were encountered: