-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added codecov support #19
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #19 +/- ##
====================================
Coverage ? 100%
====================================
Files ? 1
Lines ? 13
Branches ? 0
====================================
Hits ? 13
Misses ? 0
Partials ? 0 |
@johlju What needs to be done to fix the pip install error at the bottom of appveyor? |
Hmm... That seems yet as a new problem, the last error you get we started seeing a while back, see issue PowerShell/DscResource.Tests#203. Since the problem are escalating we should move to the alternate method mentioned in one of the last comments in the above issue in the DscResource.Tests repo. |
@TraGicCode Please rebase this PR and resolve the merge conflicts. Please use |
@TraGicCode Remember to add the Codecov badges, looked like they warn't part of the PR? 😃 |
Hey @johlju, I rebased to fix the merge conflict along with adding the codecov badges to the readme. In regards to the python issue i'm not following what alternate method we should use for this. Comments from Reviewable |
@TraGicCode Ah, sorry, it was just thinking loud that we (as in the community), in the DscResource.Tests repo, should move the test framework to use an alternate method to uploading the Codecov file. You don't have to do anything in this PR. :) We ignore the errors for now. I will review this one in a bit. 😃 |
Reviewed 2 of 3 files at r1, 1 of 1 files at r2. appveyor.yml, line 1 at r2 (raw file):
Please remove this comment block (line 1-9) appveyor.yml, line 15 at r2 (raw file):
Please change this to appveyor.yml, line 34 at r2 (raw file):
Please remove the TODO: comment block (line 34-36) README.md, line 21 at r2 (raw file):
We should set this to 'branch/dev' (at two locations in this line) Comments from Reviewable |
Review status: 1 of 3 files reviewed at latest revision, 4 unresolved discussions. appveyor.yml, line 1 at r2 (raw file): Previously, johlju (Johan Ljunggren) wrote…
Done. appveyor.yml, line 15 at r2 (raw file): Previously, johlju (Johan Ljunggren) wrote…
Done. appveyor.yml, line 34 at r2 (raw file): Previously, johlju (Johan Ljunggren) wrote…
Done. README.md, line 21 at r2 (raw file): Previously, johlju (Johan Ljunggren) wrote…
Done. Comments from Reviewable |
Reviewed 2 of 2 files at r3. Comments from Reviewable |
This enabled code coverage.
Fixes #18
This change is