Convert to DSCResource.Common - Fixes #685

[PlagueHO]

Pull Request (PR) description

Convert module to use DSCResource.Common. This also improves integration test reliability by adding Reset-DscLcm.

This Pull Request (PR) fixes the following issues

• Fixes Convert Module to use DSCResource.Common #685
• Fixes Increase Performance of Test-IsNanoServer #652
• Fixes Improve Integration Test Reliability #686

Task list

• Added an entry to the change log under the Unreleased section of the
  file CHANGELOG.md. Entry should say what was changed and how that
  affects users (if applicable), and reference the issue being resolved
  (if applicable).
• Resource documentation added/updated in README.md.
• Resource parameter descriptions added/updated in README.md, schema.mof
  and comment-based help.
• Comment-based help added/updated.
• Localization strings added/updated in all localization files as appropriate.
• Examples appropriately added/updated.
• Unit tests added/updated. See DSC Community Testing Guidelines.
• Integration tests added/updated (where possible). See DSC Community Testing Guidelines.
• New/changed code adheres to DSC Community Style Guidelines.

---

This change is 

[PlagueHO]

@johlju - would you mind reviewing this one when you have time?

[johlju]

Reviewed 57 of 57 files at r1.
Reviewable status: complete! all files reviewed, all discussions resolved

---

tests/Unit/DSC_xMsiPackage.Tests.ps1, line 808 at r1 (raw file):

-MockWith { }

We can remove these if they shouldn't mock any output. Throughout, but can be made in another PR.

[PlagueHO]

Reviewable status: complete! all files reviewed, all discussions resolved

---

tests/Unit/DSC_xMsiPackage.Tests.ps1, line 808 at r1 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

-MockWith { }

We can remove these if they shouldn't mock any output. Throughout, but can be made in another PR.

Cool. I'm going to do a full clean up of all code etc (have issues already open).