Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DSC_WebSite: Change CertificateStoreName value in the schema #641

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

webalexeu
Copy link

@webalexeu webalexeu commented Oct 17, 2024

Pull Request (PR) description

Change CertificateStoreName value in the schema to match the value returned by DSC
This is aligned with the testing defined

certificateStoreName = 'MY'

This Pull Request (PR) fixes the following issues

Fixes #642

Task list

  • Added an entry to the change log under the Unreleased section of the file CHANGELOG.md.
    Entry should say what was changed and how that affects users (if applicable), and
    reference the issue being resolved (if applicable).
  • Resource documentation added/updated in README.md.
  • Resource parameter descriptions added/updated in README.md, schema.mof and comment-based
    help.
  • Comment-based help added/updated.
  • Localization strings added/updated in all localization files as appropriate.
  • Examples appropriately added/updated.
  • Unit tests added/updated. See DSC Community Testing Guidelines.
  • Integration tests added/updated (where possible). See DSC Community Testing Guidelines.
  • New/changed code adheres to DSC Community Style Guidelines.

This change is Reviewable

Change CertificateStoreName value
Align documentation
Copy link

codecov bot commented Oct 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88%. Comparing base (da0cd60) to head (23cbe10).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@         Coverage Diff         @@
##           main   #641   +/-   ##
===================================
  Coverage    88%    88%           
===================================
  Files        15     15           
  Lines      1952   1952           
===================================
  Hits       1726   1726           
  Misses      226    226           

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] DSC_WebSite: CertificateStoreName value is not mathing defined value in the schema
1 participant