Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MSFT_MountImage - Correcting example for dismounting an ISO image #222

Closed
wants to merge 5 commits into from

Conversation

wsmelton
Copy link

@wsmelton wsmelton commented Dec 22, 2019

Pull Request (PR) description

The drive letter should not be provided when wanting to ensure an ISO is no longer mounted.

This Pull Request (PR) fixes the following issues

Task list

  • Added an entry under the Unreleased section of the change log in the CHANGELOG.md.
    Entry should say what was changed, and how that affects users (if applicable).
  • Resource documentation added/updated in README.md in the resource folder.
  • Resource parameter descriptions added/updated in schema.mof
    and comment-based help.
  • Comment-based help added/updated.
  • Localization strings added/updated in all localization files as appropriate.
  • Examples appropriately added/updated.
  • Unit tests added/updated. See DSC Resource Testing Guidelines.
  • Integration tests added/updated (where possible). See DSC Resource Testing Guidelines.
  • New/changed code adheres to DSC Resource Style Guidelines and Best Practices.

This change is Reviewable

PlagueHO and others added 4 commits November 16, 2019 20:24
The drive letter should not be provided when wanting to ensure an ISO is no longer mounted.
@PlagueHO PlagueHO closed this Dec 24, 2019
@PlagueHO PlagueHO reopened this Dec 24, 2019
@PlagueHO
Copy link
Member

Sorry about the delay @wsmelton - we've been a bit focused on the migration process over to the DSC Community. I've updated the build so that we can get this through.

@codecov
Copy link

codecov bot commented Dec 24, 2019

Codecov Report

Merging #222 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@        Coverage Diff         @@
##           dev   #222   +/-   ##
==================================
  Coverage   95%    95%           
==================================
  Files        7      7           
  Lines      985    985           
==================================
  Hits       943    943           
  Misses      42     42

@PlagueHO
Copy link
Member

Hi @wsmelton - can you resolve the conflicts and correct the error: https://ci.appveyor.com/project/dsccommunity/storagedsc/builds/29743806?fullLog=true#L615

It just looks like the line length in the CHANGELOG.MD is beyond the 80 char limit.

@wsmelton
Copy link
Author

So this would assume then that your test does not account for URL links being provided? If you ignore the URL link the whole line is only 71 characters.

Remove reference link
@PlagueHO PlagueHO changed the base branch from dev to master April 14, 2020 20:23
@PlagueHO
Copy link
Member

PlagueHO commented May 3, 2020

Hi @wsmelton - now that we've updated to the new pipeline/structure, are you still keen to complete this one?

@PlagueHO PlagueHO added the abandoned The pull request has been abandoned. label Dec 1, 2020
@PlagueHO PlagueHO closed this Dec 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
abandoned The pull request has been abandoned.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MSFT_MountImage - Dismounting an image fails Window Server 2019
2 participants