DiskAccessPath Add Disk Subsystem Refresh before set - Fixes #121

[PlagueHO]

Pull Request (PR) description

• DiskAccessPath:
  • Added function to force refresh of disk subsystem at the start of
    Set-TargetResource to prevent errors occuring when the disk access
    path is already assigned - See Issue 121

This PR also supercedes #152, #126

This Pull Request (PR) fixes the following issues

• Fixes xDiskAccessPath fails test for disk and accesspath after disk format and folder creation. #121

Task list

• Added an entry under the Unreleased section of the change log in the CHANGELOG.md.
  Entry should say what was changed, and how that affects users (if applicable).
• Resource documentation added/updated in README.md in the resource folder.
• Resource parameter descriptions added/updated in schema.mof
  and comment-based help.
• Comment-based help added/updated.
• Localization strings added/updated in all localization files as appropriate.
• Examples appropriately added/updated.
• Unit tests added/updated. See DSC Resource Testing Guidelines.
• Integration tests added/updated (where possible). See DSC Resource Testing Guidelines.
• New/changed code adheres to DSC Resource Style Guidelines and Best Practices.

@johlju - would you mind reviewing this when you get a chance?

---

This change is 

[codecov-io]

Codecov Report

Merging #209 into dev will increase coverage by <1%.
The diff coverage is 100%.

@@         Coverage Diff         @@
##           dev   #209    +/-   ##
===================================
+ Coverage   95%    95%   +<1%     
===================================
  Files        7      7            
  Lines      958    978    +20     
===================================
+ Hits       917    937    +20     
  Misses      41     41

[johlju]

Reviewed 5 of 5 files at r1.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @PlagueHO)

---

DSCResources/MSFT_DiskAccessPath/MSFT_DiskAccessPath.psm1, line 761 at r1 (raw file):

<#
    .SYNOPSIS
    Check access path is found in PSDrives.

The text should be indented one more step. Throughout.

---

DSCResources/MSFT_DiskAccessPath/MSFT_DiskAccessPath.psm1, line 771 at r1 (raw file):

wihtout

typo

---

DSCResources/MSFT_DiskAccessPath/MSFT_DiskAccessPath.psm1, line 810 at r1 (raw file):

$accessPathDrive

Maybe add a verbose message saying if the access path was found or not? 🤔

[johlju]

Reviewable status: all files reviewed, 5 unresolved discussions (waiting on @PlagueHO)

---

DSCResources/MSFT_DiskAccessPath/MSFT_DiskAccessPath.psm1, line 797 at r1 (raw file):

$localizedData

$script:localizedData

---

DSCResources/MSFT_DiskAccessPath/MSFT_DiskAccessPath.psm1, line 806 at r1 (raw file):

$localizedData

$script:localizedData

[PlagueHO]

Thanks @johlju - should be good to go!

Reviewable status: 2 of 9 files reviewed, 4 unresolved discussions (waiting on @johlju)

---

DSCResources/MSFT_DiskAccessPath/MSFT_DiskAccessPath.psm1, line 761 at r1 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

The text should be indented one more step. Throughout.

Done. And also in all the other files 😁

---

DSCResources/MSFT_DiskAccessPath/MSFT_DiskAccessPath.psm1, line 771 at r1 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

wihtout

typo

Done.

---

DSCResources/MSFT_DiskAccessPath/MSFT_DiskAccessPath.psm1, line 797 at r1 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

$localizedData

$script:localizedData

Done.

---

DSCResources/MSFT_DiskAccessPath/MSFT_DiskAccessPath.psm1, line 806 at r1 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

$localizedData

$script:localizedData

Done.

[johlju]

Reviewed 7 of 7 files at r2.
Reviewable status: complete! all files reviewed, all discussions resolved

[PlagueHO]

Thanks @johlju !!!