Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up unit tests for DiskAccessPath - Fixes #199 #201

Merged
merged 1 commit into from
Mar 25, 2019

Conversation

PlagueHO
Copy link
Member

@PlagueHO PlagueHO commented Mar 8, 2019

Pull Request (PR) description

This PR corrects the unit tests for DiskAccessPath to meet current standards and ensure -Exactly is included in all Assert-MockCalled checks.

This Pull Request (PR) fixes the following issues

Task list

  • Added an entry under the Unreleased section of the change log in the CHANGELOG.md.
    Entry should say what was changed, and how that affects users (if applicable).
  • Resource documentation added/updated in README.md in the resource folder.
  • Resource parameter descriptions added/updated in schema.mof
    and comment-based help.
  • Comment-based help added/updated.
  • Localization strings added/updated in all localization files as appropriate.
  • Examples appropriately added/updated.
  • Unit tests added/updated. See DSC Resource Testing Guidelines.
  • Integration tests added/updated (where possible). See DSC Resource Testing Guidelines.
  • New/changed code adheres to DSC Resource Style Guidelines and Best Practices.

@johlju - would you mind reviewing this one?


This change is Reviewable

@PlagueHO PlagueHO added the needs review The pull request needs a code review. label Mar 8, 2019
@codecov-io
Copy link

Codecov Report

Merging #201 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@        Coverage Diff         @@
##           dev   #201   +/-   ##
==================================
  Coverage   94%    94%           
==================================
  Files        8      8           
  Lines      889    889           
==================================
  Hits       837    837           
  Misses      52     52

@PlagueHO
Copy link
Member Author

Hi @johlju - would you mind reviewing this one for me when you have a moment? Just a bit of a cleanup on some tests.

Copy link
Member

@johlju johlju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Looking good!

Reviewed 2 of 2 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@PlagueHO PlagueHO merged commit 54fadad into dsccommunity:dev Mar 25, 2019
@kwirkykat kwirkykat removed the needs review The pull request needs a code review. label Mar 25, 2019
@PlagueHO PlagueHO deleted the Issue-199 branch March 25, 2019 05:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Assert-MockCallled for Unit Tests for DiskAccessPath do not check Exactly
4 participants