Refactor Module to remove Harness Structure - Fixes #169

[PlagueHO]

Pull Request (PR) description

This PR refactors the module structure to remove the need for a test harness.

It also updates the module to submit examples to the PS Gallery.

This Pull Request (PR) fixes the following issues

• Fixes Refactor Repository Folder Structure so Harness not Required #169

Task list

• Added an entry under the Unreleased section of the change log in the CHANGELOG.md.
  Entry should say what was changed, and how that affects users (if applicable).
• Resource documentation added/updated in README.md in the resource folder.
• Resource parameter descriptions added/updated in schema.mof
  and comment-based help.
• Comment-based help added/updated.
• Localization strings added/updated in all localization files as appropriate.
• Examples appropriately added/updated.
• Unit tests added/updated. See DSC Resource Testing Guidelines.
• Integration tests added/updated (where possible). See DSC Resource Testing Guidelines.
• New/changed code adheres to DSC Resource Style Guidelines and Best Practices.

@johlju - would you mind reviewing at some point? It is a bit of a large one, but is mainly just moving files around.

---

This change is 

[codecov-io]

Codecov Report

Merging #182 into dev will decrease coverage by <1%.
The diff coverage is n/a.

@@        Coverage Diff         @@
##           dev   #182   +/-   ##
==================================
- Coverage   94%    94%   -1%     
==================================
  Files        6      8    +2     
  Lines      799    873   +74     
==================================
+ Hits       758    821   +63     
- Misses      41     52   +11

[johlju]

Will continue later :) Looks good so far

Reviewed 41 of 75 files at r1.
Reviewable status: 41 of 75 files reviewed, 1 unresolved discussion (waiting on @PlagueHO)

---

CHANGELOG.md, line 10 at r1 (raw file):

CODE_OF_CONDUCT

We should escape these? CODE\_OF\_CONDUCT

[johlju]

Just two minor issues.

Reviewed 34 of 75 files at r1.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @PlagueHO)

---

Tests/Unit/StorageDsc.Common.Tests.ps1, line 14 at r1 (raw file):

}

Import-Module (Join-Path -Path $script:moduleRoot -ChildPath 'DSCResource.Tests\TestHelper.psm1') -Force

This should have -Nametoo?

---

Examples/Resources/WaitForDisk/3-WaitForDisk_InitializeDataDiskWithAccessPath.ps1, line 26 at r1 (raw file):

        available space after c:\SQLData has been created.
#>
Configuration WaitForDisk_InitializeDataDiskWithAccessPath

This is named exactly as the previous example in file '2-...'.

[PlagueHO]

Thank you so much for reviewing @johlju - great job as always and very thorough! I've completed all requested changes.

Reviewable status: 57 of 75 files reviewed, 3 unresolved discussions (waiting on @johlju)

---

CHANGELOG.md, line 10 at r1 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

CODE_OF_CONDUCT

We should escape these? CODE\_OF\_CONDUCT

Done.

---

Tests/Unit/StorageDsc.Common.Tests.ps1, line 14 at r1 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

This should have -Nametoo?

Done. And throughout all tests.

---

Examples/Resources/WaitForDisk/3-WaitForDisk_InitializeDataDiskWithAccessPath.ps1, line 26 at r1 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

This is named exactly as the previous example in file '2-...'.

This was a duplicate so have removed it completely!

[johlju]

Happy to help out! 😃

Reviewed 18 of 18 files at r2.
Reviewable status: complete! all files reviewed, all discussions resolved

[PlagueHO]

Thank you so much @johlju!