-
Notifications
You must be signed in to change notification settings - Fork 225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SqlServerDsc: Add a CODE_OF_CONDUCT.md #940
Conversation
I'm not sure I see the value in retaining the code of conduct in the README file with the addition of the CODE_OF_CONDUCT file. If it's best practice to have a separate code of conduct file, I think it should be removed from the README at the same time it is added to the code of conduct file. Review status: 0 of 2 files reviewed at latest revision, all discussions resolved. Comments from Reviewable |
@randomnote1 I agree. Raised the question in PowerShell/DscResources#337 just to be sure there is no legal issue by removing it. :) Lets keep this open until we get answer on that issue. |
9ea4d1b
to
9b323a5
Compare
Codecov Report
@@ Coverage Diff @@
## dev #940 +/- ##
===================================
Coverage 97% 97%
===================================
Files 33 33
Lines 4003 4003
===================================
Hits 3914 3914
Misses 89 89 |
9b323a5
to
d1e1a03
Compare
d1e1a03
to
f6a7703
Compare
f6a7703
to
3ebae2b
Compare
- Added a CODE_OF_CONDUCT.md with the same content as in the README.md (issue dsccommunity#939).
3ebae2b
to
b41f413
Compare
Reviewed 2 of 2 files at r1, 1 of 1 files at r3. Comments from Reviewable |
Pull Request (PR) description
This Pull Request (PR) fixes the following issues:
Fixes #939
Task list:
This change is