Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SqlServerDsc: Add a CODE_OF_CONDUCT.md #940

Merged
merged 4 commits into from
Jun 9, 2018

Conversation

johlju
Copy link
Member

@johlju johlju commented Dec 7, 2017

Pull Request (PR) description

This Pull Request (PR) fixes the following issues:
Fixes #939

Task list:

  • Change details added to Unreleased section of CHANGELOG.md?
  • Added/updated documentation, comment-based help and descriptions in .schema.mof files where appropriate?
  • Examples appropriately updated?
  • New/changed code adheres to Style Guidelines?
  • Unit and (optional) Integration tests created/updated where possible?

This change is Reviewable

@johlju johlju added the needs review The pull request needs a code review. label Dec 7, 2017
@randomnote1
Copy link
Contributor

I'm not sure I see the value in retaining the code of conduct in the README file with the addition of the CODE_OF_CONDUCT file. If it's best practice to have a separate code of conduct file, I think it should be removed from the README at the same time it is added to the code of conduct file.


Review status: 0 of 2 files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@johlju
Copy link
Member Author

johlju commented Dec 7, 2017

@randomnote1 I agree. Raised the question in PowerShell/DscResources#337 just to be sure there is no legal issue by removing it. :)

Lets keep this open until we get answer on that issue.

@johlju johlju added waiting for author response The pull request is waiting for the author to respond to comments in the pull request. on hold The issue or pull request has been put on hold by a maintainer. and removed needs review The pull request needs a code review. waiting for author response The pull request is waiting for the author to respond to comments in the pull request. labels Dec 7, 2017
@johlju johlju force-pushed the fix-code-of-conduct branch from 9ea4d1b to 9b323a5 Compare December 23, 2017 10:57
@codecov-io
Copy link

codecov-io commented Dec 23, 2017

Codecov Report

Merging #940 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@         Coverage Diff         @@
##            dev   #940   +/-   ##
===================================
  Coverage    97%    97%           
===================================
  Files        33     33           
  Lines      4003   4003           
===================================
  Hits       3914   3914           
  Misses       89     89

johlju added 2 commits June 8, 2018 16:28
- Added a CODE_OF_CONDUCT.md with the same content as in the README.md (issue dsccommunity#939).
@johlju johlju added waiting for code fix A review left open comments, and the pull request is waiting for changes to be pushed by the author. and removed on hold The issue or pull request has been put on hold by a maintainer. labels Jun 8, 2018
@johlju johlju force-pushed the fix-code-of-conduct branch from 3ebae2b to b41f413 Compare June 8, 2018 14:30
@johlju johlju added needs review The pull request needs a code review. and removed waiting for code fix A review left open comments, and the pull request is waiting for changes to be pushed by the author. labels Jun 8, 2018
@johlju
Copy link
Member Author

johlju commented Jun 9, 2018

:LGTM:


Reviewed 2 of 2 files at r1, 1 of 1 files at r3.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@johlju johlju merged commit 06b0e2d into dsccommunity:dev Jun 9, 2018
@johlju johlju deleted the fix-code-of-conduct branch July 7, 2018 18:28
@johlju johlju removed the needs review The pull request needs a code review. label Apr 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SqlServerDsc: Add a CODE_OF_CONDUCT.md
3 participants