Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xSQLServerAlwaysOnAvailabilityGroupDatabaseMembership: Make Cluster Aware #895

Merged
merged 3 commits into from
Oct 30, 2017
Merged

xSQLServerAlwaysOnAvailabilityGroupDatabaseMembership: Make Cluster Aware #895

merged 3 commits into from
Oct 30, 2017

Conversation

randomnote1
Copy link
Contributor

@randomnote1 randomnote1 commented Oct 27, 2017

Pull Request (PR) description
Updated the xSQLServerAlwaysOnAvailabilityGroupDatabaseMembership resource to be cluster aware.

This Pull Request (PR) fixes the following issues:
Fixes #869

Task list:

  • Change details added to Unreleased section of CHANGELOG.md?
  • Added/updated documentation, comment-based help and descriptions in .schema.mof files where appropriate?
  • Examples appropriately updated?
  • New/changed code adheres to Style Guidelines?
  • Unit and (optional) Integration tests created/updated where possible?

This change is Reviewable

@codecov-io
Copy link

codecov-io commented Oct 27, 2017

Codecov Report

Merging #895 into dev will increase coverage by <1%.
The diff coverage is 100%.

Impacted file tree graph

@@         Coverage Diff          @@
##            dev   #895    +/-   ##
====================================
+ Coverage    96%    96%   +<1%     
====================================
  Files        31     32     +1     
  Lines      3447   3503    +56     
====================================
+ Hits       3327   3383    +56     
  Misses      120    120

@johlju johlju added the needs review The pull request needs a code review. label Oct 27, 2017
@johlju
Copy link
Member

johlju commented Oct 27, 2017

Great work! Looks like you change these fast now! Found just one tiny comment. 😄


Reviewed 8 of 8 files at r1.
Review status: all files reviewed at latest revision, 1 unresolved discussion.


DSCResources/MSFT_xSQLServerAlwaysOnAvailabilityGroupDatabaseMembership/en-US/MSFT_xSQLServerAlwaysOnAvailabilityGroupDatabaseMembership.strings.psd1, line 11 at r1 (raw file):

    DatabasesNotFound = The following databases were not found in the instance: {0}.
    ImpersonatePermissionsMissing = The login '{0}' is missing impersonate permissions in the instances '{1}'.
    NotActiveNode = The node "{0}" is not actively hosting the instance "{1}". Exiting the test.

Should there be single quotes in this one too to be consequent? Or is it better with double quotes?


Comments from Reviewable

@johlju johlju added waiting for author response The pull request is waiting for the author to respond to comments in the pull request. and removed needs review The pull request needs a code review. labels Oct 27, 2017
@randomnote1
Copy link
Contributor Author

Yup, figured out a process!


Review status: 7 of 8 files reviewed at latest revision, 1 unresolved discussion.


DSCResources/MSFT_xSQLServerAlwaysOnAvailabilityGroupDatabaseMembership/en-US/MSFT_xSQLServerAlwaysOnAvailabilityGroupDatabaseMembership.strings.psd1, line 11 at r1 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

Should there be single quotes in this one too to be consequent? Or is it better with double quotes?

I like double-quotes, but to be consistent with the rest of the strings I updated to single quotes.

Done.


Comments from Reviewable

@johlju johlju added needs review The pull request needs a code review. and removed waiting for author response The pull request is waiting for the author to respond to comments in the pull request. labels Oct 30, 2017
@johlju
Copy link
Member

johlju commented Oct 30, 2017

:lgtm:


Reviewed 1 of 1 files at r2.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@johlju johlju merged commit 88bcd27 into dsccommunity:dev Oct 30, 2017
@vors vors removed the needs review The pull request needs a code review. label Oct 30, 2017
@randomnote1 randomnote1 deleted the xSQLServerAlwaysOnAvailabilityGroupDatabaseMembershipMakeClusterAware branch October 30, 2017 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

xSQLServerAlwaysOnAvailabilityGroupDatabaseMembership: Should Be Cluster Aware
4 participants