Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xSQLServerRSConfig: Adding examples #852

Merged
merged 2 commits into from
Oct 19, 2017

Conversation

bozho
Copy link
Contributor

@bozho bozho commented Sep 28, 2017

Pull Request (PR) description
Added examples for xSQLServerRSConfig resource.

This Pull Request (PR) fixes the following issues:
Fixes #844

Task list:

  • Change details added to Unreleased section of CHANGELOG.md?
  • Added/updated documentation, comment-based help and descriptions in .schema.mof files where appropriate?
  • Examples appropriately updated?
  • New/changed code adheres to Style Guidelines?
  • Unit and (optional) Integration tests created/updated where possible?

This change is Reviewable

@codecov-io
Copy link

codecov-io commented Sep 28, 2017

Codecov Report

Merging #852 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@         Coverage Diff         @@
##            dev   #852   +/-   ##
===================================
  Coverage    96%    96%           
===================================
  Files        31     31           
  Lines      3436   3436           
===================================
  Hits       3317   3317           
  Misses      119    119

@johlju
Copy link
Member

johlju commented Oct 2, 2017

@johlju johlju changed the title [#844] xSQLServerRSConfig examples xSQLServerRSConfig: Adding examples Oct 2, 2017
@johlju
Copy link
Member

johlju commented Oct 2, 2017

Please also add an entry to the CHANGELOG.md.

@johlju johlju added the waiting for author response The pull request is waiting for the author to respond to comments in the pull request. label Oct 2, 2017
@johlju
Copy link
Member

johlju commented Oct 2, 2017

Please also add these examples to the README.md. See others resources examples for the correct layout.

@johlju
Copy link
Member

johlju commented Oct 7, 2017

@bozho Do you have time to resolve the comments above?

  • Resolve the failing tests.
  • Add an entry to the CHANGELOG.md
  • Add these examples to the README.md. See others resources examples for the correct layout.

Also. Please rebase this PR, and make sure to move the entries in the CHANGELOG.md back to the Unreleased section after rebase. This is due to the recent release of the module.

@bozho bozho force-pushed the issue-844-ssrs-examples branch from a2a55a6 to da39d6a Compare October 19, 2017 12:21
@bozho
Copy link
Contributor Author

bozho commented Oct 19, 2017

@johlju Sorry for the delay, life interfered :)

@johlju
Copy link
Member

johlju commented Oct 19, 2017

@bozho No worries :) Glad you are back.

@johlju
Copy link
Member

johlju commented Oct 19, 2017

:lgtm:


Reviewed 1 of 2 files at r1, 3 of 3 files at r2.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@johlju johlju removed the waiting for author response The pull request is waiting for the author to respond to comments in the pull request. label Oct 19, 2017
@johlju johlju merged commit 5d7af04 into dsccommunity:dev Oct 19, 2017
@bozho bozho deleted the issue-844-ssrs-examples branch October 23, 2017 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

xSQLServerRSConfig: Add examples for the new parameters in this resource
3 participants