-
Notifications
You must be signed in to change notification settings - Fork 225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
xSQLServerRSConfig: Adding examples #852
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #852 +/- ##
===================================
Coverage 96% 96%
===================================
Files 31 31
Lines 3436 3436
===================================
Hits 3317 3317
Misses 119 119 |
Please resolve the failing tests |
Please also add an entry to the CHANGELOG.md. |
Please also add these examples to the README.md. See others resources examples for the correct layout. |
@bozho Do you have time to resolve the comments above?
Also. Please rebase this PR, and make sure to move the entries in the CHANGELOG.md back to the Unreleased section after rebase. This is due to the recent release of the module. |
a2a55a6
to
da39d6a
Compare
@johlju Sorry for the delay, life interfered :) |
@bozho No worries :) Glad you are back. |
Reviewed 1 of 2 files at r1, 3 of 3 files at r2. Comments from Reviewable |
Pull Request (PR) description
Added examples for xSQLServerRSConfig resource.
This Pull Request (PR) fixes the following issues:
Fixes #844
Task list:
This change is