Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xSQLServerAlwaysOnAvailabilityGroup\Replica: Utilize the Get-PrimaryReplicaServerObject helper function #842

Merged
merged 4 commits into from
Sep 22, 2017
Merged

xSQLServerAlwaysOnAvailabilityGroup\Replica: Utilize the Get-PrimaryReplicaServerObject helper function #842

merged 4 commits into from
Sep 22, 2017

Conversation

randomnote1
Copy link
Contributor

@randomnote1 randomnote1 commented Sep 22, 2017

Pull Request (PR) description
Updated xSQLServerAlwaysOnAvailabilityGroup and xSQLServerAlwaysOnAvailabilityGroupReplica to utilize the Get-PrimaryReplicaServerObject helper function.

This Pull Request (PR) fixes the following issues:
Fixes #630

Task list:

  • Change details added to Unreleased section of CHANGELOG.md?
  • Added/updated documentation, comment-based help and descriptions in .schema.mof files where appropriate?
  • Examples appropriately updated?
  • New/changed code adheres to Style Guidelines?
  • Unit and (optional) Integration tests created/updated where possible?

This change is Reviewable

@codecov-io
Copy link

codecov-io commented Sep 22, 2017

Codecov Report

Merging #842 into dev will decrease coverage by <1%.
The diff coverage is 100%.

Impacted file tree graph

@@         Coverage Diff         @@
##            dev   #842   +/-   ##
===================================
- Coverage    96%    96%   -1%     
===================================
  Files        31     31           
  Lines      3314   3311    -3     
===================================
- Hits       3197   3194    -3     
  Misses      117    117

@johlju johlju added the needs review The pull request needs a code review. label Sep 22, 2017
@johlju
Copy link
Member

johlju commented Sep 22, 2017

:lgtm:


Reviewed 2 of 2 files at r1, 3 of 3 files at r2.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@johlju johlju merged commit 5d99b62 into dsccommunity:dev Sep 22, 2017
@vors vors removed the needs review The pull request needs a code review. label Sep 22, 2017
@johlju
Copy link
Member

johlju commented Sep 22, 2017

Awesome work! 😄

@randomnote1 randomnote1 deleted the UseGetPrimaryReplicaServerObjectHelperFunction branch September 22, 2017 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

xSQLServerAlwaysOnAvailabilityGroup/Replica: Utilize the help function Get-PrimaryReplicaServerObject
5 participants