Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xSQLServer: Quick fix for breaking changes in Pester #813

Merged
merged 1 commit into from
Sep 14, 2017

Conversation

johlju
Copy link
Member

@johlju johlju commented Sep 14, 2017

Pull Request (PR) description

This Pull Request (PR) fixes the following issues:
This does not fix the issue - just a workaround until we fix the problems in the unit tests.

Task list:

  • Change details added to Unreleased section of CHANGELOG.md?
  • Added/updated documentation, comment-based help and descriptions in .schema.mof files where appropriate?
  • Examples appropriately updated?
  • New/changed code adheres to Style Guidelines?
  • Unit and (optional) Integration tests created/updated where possible?

This change is Reviewable

- Changed so the maximum version to be installed is 4.0.6.0. Quick fix until we
  can resolve the unit tests (see issue dsccommunity#807).
@johlju johlju added bug The issue is a bug. needs review The pull request needs a code review. and removed bug The issue is a bug. labels Sep 14, 2017
@johlju
Copy link
Member Author

johlju commented Sep 14, 2017

I will merge this as soon as the tests passes.

@codecov-io
Copy link

codecov-io commented Sep 14, 2017

Codecov Report

Merging #813 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@         Coverage Diff         @@
##            dev   #813   +/-   ##
===================================
  Coverage    96%    96%           
===================================
  Files        30     30           
  Lines      3259   3259           
===================================
  Hits       3142   3142           
  Misses      117    117

@johlju johlju removed the needs review The pull request needs a code review. label Sep 14, 2017
@johlju
Copy link
Member Author

johlju commented Sep 14, 2017

:LGTM:


Reviewed 2 of 2 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@johlju johlju merged commit 97af610 into dsccommunity:dev Sep 14, 2017
@johlju johlju deleted the quick-fix-pester branch September 17, 2017 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants