Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xSQLServerAlwaysOnAvailabilityGroupReplica: Added EndpointPort and EndpointUrl as read-only properties to the schema #803

Merged
merged 1 commit into from
Sep 13, 2017
Merged

xSQLServerAlwaysOnAvailabilityGroupReplica: Added EndpointPort and EndpointUrl as read-only properties to the schema #803

merged 1 commit into from
Sep 13, 2017

Conversation

randomnote1
Copy link
Contributor

@randomnote1 randomnote1 commented Sep 12, 2017

Pull Request (PR) description
Added EndpointPort and EndpointUrl as read-only properties to the schema.

This Pull Request (PR) fixes the following issues:
Fixes: #477

Task list:

  • Change details added to Unreleased section of CHANGELOG.md?
  • Added/updated documentation, comment-based help and descriptions in .schema.mof files where appropriate?
  • Examples appropriately updated?
  • New/changed code adheres to Style Guidelines?
  • Unit and (optional) Integration tests created/updated where possible?

This change is Reviewable

…LServerAlwaysOnAvailabilityGroupReplica schema.
@codecov-io
Copy link

codecov-io commented Sep 12, 2017

Codecov Report

Merging #803 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@         Coverage Diff         @@
##            dev   #803   +/-   ##
===================================
  Coverage    96%    96%           
===================================
  Files        30     30           
  Lines      3256   3256           
===================================
  Hits       3139   3139           
  Misses      117    117

@johlju johlju added the needs review The pull request needs a code review. label Sep 13, 2017
@johlju
Copy link
Member

johlju commented Sep 13, 2017

:lgtm:


Reviewed 3 of 3 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@johlju johlju merged commit dbca42c into dsccommunity:dev Sep 13, 2017
@vors vors removed the needs review The pull request needs a code review. label Sep 13, 2017
@randomnote1 randomnote1 deleted the xSQLServerAlwaysOnAvailabilityGroupReplicaFixes branch September 13, 2017 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

xSQLServerAlwaysOnAvailabilityGroupReplica: Hash table returned from get-method does not match schema
5 participants