xSQLServer: Using correct assemblies for module SqlServer #800
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now it correctly loads the correct assemblies when SqlServer module is present (issue dsccommunity#649). Now SQLPS module will be correctly loaded (discovered) after installation of SQL Server (issue dsccommunity#659). Previously resources depending on SQLPS module could fail because SQLPS was not found after installation because the PSModulePath environment variable in the (LCM) PowerShell session did not contain the new module path.
- Changes to xSQLServer - Updated appveyor.yml so that integration tests can run in AppVeyor (issue dsccommunity#774). - Changes to xSQLServerSetup - Fixed so that the integration test copies back the SQLPS module (issue dsccommunity#774).
- Fixed so integration test does not write warnings when SQLPS module is loaded (issue dsccommunity#798).
johlju
changed the title
Codecov Report
@@ Coverage Diff @@
## dev #800 +/- ##
===================================
- Coverage 97% 96% -1%
===================================
Files 30 30
Lines 3255 3256 +1
===================================
- Hits 3170 3139 -31
- Misses 85 117 +32 |
|
Reviewed 2 of 3 files at r1, 4 of 4 files at r3. Comments from Reviewable |
|
Reviewed 2 of 3 files at r1, 4 of 4 files at r3. Comments from Reviewable |
all files reviewed at latest revision, all discussions resolved, all commit checks successful.
|
@randomnote1 Big thanks for reviewing this for me! |
johlju
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
the SQLPS module folders are renamed to not disturb the units test, but
can be renamed back by the integration tests xSQLServerSetup so that the
integration tests can run successfully.
(issue xSQLServer: Problem running integration tests with fixes in issue #649 #774).
present (issue xSQLServerAlwaysOnAvailabilityGroup: SqlServer Module v21.0.17099 breaks the resource #649).
of SQL Server. Previously resources depending on SQLPS module could fail
because SQLPS was not found after installation because the PSModulePath
environment variable in the (LCM) PowerShell session did not contain the new
module path.
they was renamed by AppVeyor (in the appveyor.yml file).
(issue xSQLServer: Problem running integration tests with fixes in issue #649 #774).
(issue xSQLServerSetup: Getting warnings when running integration test #798).
This Pull Request (PR) fixes the following issues:
Fixes #649
Fixes #774
Fixes #798
Task list:
This change is