Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xSQLServer: Fixed typos and the use of wrong parameters in unit tests #777

Merged
merged 1 commit into from
Aug 19, 2017

Conversation

johlju
Copy link
Member

@johlju johlju commented Aug 18, 2017

Pull Request (PR) description

This Pull Request (PR) fixes the following issues:
Fixes #773

Task list:

  • Change details added to Unreleased section of CHANGELOG.md?
  • Added/updated documentation, comment-based help and descriptions in .schema.mof files where appropriate?
  • Examples appropriately updated?
  • New/changed code adheres to Style Guidelines?
  • Unit and (optional) Integration tests created/updated where possible?

This change is Reviewable

- Fixed typos and the use of wrong parameters in unit tests which was
  found after release of new version of Pester (issue dsccommunity#773).
@johlju johlju added the needs review The pull request needs a code review. label Aug 18, 2017
@codecov-io
Copy link

codecov-io commented Aug 18, 2017

Codecov Report

Merging #777 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@         Coverage Diff         @@
##            dev   #777   +/-   ##
===================================
  Coverage    97%    97%           
===================================
  Files        30     30           
  Lines      3250   3250           
===================================
  Hits       3165   3165           
  Misses       85     85

@johlju
Copy link
Member Author

johlju commented Aug 19, 2017

:lgtm:


Reviewed 16 of 16 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@johlju johlju merged commit 4734f66 into dsccommunity:dev Aug 19, 2017
@vors vors removed the needs review The pull request needs a code review. label Aug 19, 2017
@johlju johlju deleted the pester-issues branch August 19, 2017 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

xSQLServer: New Pester version released to PowerShell Gallery breaks tests
4 participants