Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xSQLServer: Opt-in for script files common tests #708

Merged
merged 1 commit into from
Jul 24, 2017

Conversation

johlju
Copy link
Member

@johlju johlju commented Jul 22, 2017

Pull Request (PR) description

  • Changes to xSQLServer
    • Opt-in for script files common tests (issue xSQLServer: Opt-in for script files common tests #707).
      • Removed Byte Order Mark (BOM) from the files; DSCClusterSqlBuild.ps1,
        DSCFCISqlBuild.ps1, DSCSqlBuild.ps1, DSCSQLBuildEncrypted.ps1,
        SQLPush_SingleServer.ps1, 1-AddAvailabilityGroupListenerWithSameNameAsVCO.ps1,
        2-AddAvailabilityGroupListenerWithDifferentNameAsVCO.ps1,
        3-RemoveAvailabilityGroupListenerWithSameNameAsVCO.ps1,
        4-RemoveAvailabilityGroupListenerWithDifferentNameAsVCO.ps1,
        5-AddAvailabilityGroupListenerUsingDHCPWithDefaultServerSubnet.ps1,
        6-AddAvailabilityGroupListenerUsingDHCPWithSpecificSubnet.ps1,
        2-ConfigureInstanceToEnablePriorityBoost.ps1, 1-CreateEndpointWithDefaultValues.ps1,
        2-CreateEndpointWithSpecificPortAndIPAddress.ps1, 3-RemoveEndpoint.ps1,
        1-AddConnectPermission.ps1, 2-RemoveConnectPermission.ps1,
        3-AddConnectPermissionToAlwaysOnPrimaryAndSecondaryReplicaEachWithDifferentSqlServiceAccounts.ps1,
        4-RemoveConnectPermissionToAlwaysOnPrimaryAndSecondaryReplicaEachWithDifferentSqlServiceAccounts.ps1,
        1-MakeSureEndpointIsStarted.ps1, 2-MakeSureEndpointIsStopped.ps1,
        1-EnableTcpIpWithStaticPort.ps1, 2-EnableTcpIpWithDynamicPort.ps1,
        1-AddServerPermissionForLogin.ps1, 2-RemoveServerPermissionForLogin.ps1,
        1-ConfigureInstanceAsDistributor.ps1, 2-ConfigureInstanceAsPublisher.ps1,
        1-WaitForASingleClusterGroup.ps1, 2-WaitForMultipleClusterGroups.ps1.

This Pull Request (PR) fixes the following issues:
Fixes #707

Task list:

  • Change details added to Unreleased section of CHANGELOG.md?
  • Added/updated documentation, comment-based help and descriptions in .schema.mof files where appropriate?
  • Examples appropriately updated?
  • New/changed code adheres to Style Guidelines?
  • Unit and (optional) Integration tests created/updated where possible?

This change is Reviewable

Opt-in for script files common tests (issue dsccommunity#707).
  - Removed Byte Order Mark (BOM) from the files; DSCClusterSqlBuild.ps1,
    DSCFCISqlBuild.ps1, DSCSqlBuild.ps1, DSCSQLBuildEncrypted.ps1,
    SQLPush_SingleServer.ps1, 1-AddAvailabilityGroupListenerWithSameNameAsVCO.ps1,
    2-AddAvailabilityGroupListenerWithDifferentNameAsVCO.ps1,
    3-RemoveAvailabilityGroupListenerWithSameNameAsVCO.ps1,
    4-RemoveAvailabilityGroupListenerWithDifferentNameAsVCO.ps1,
    5-AddAvailabilityGroupListenerUsingDHCPWithDefaultServerSubnet.ps1,
    6-AddAvailabilityGroupListenerUsingDHCPWithSpecificSubnet.ps1,
    2-ConfigureInstanceToEnablePriorityBoost.ps1, 1-CreateEndpointWithDefaultValues.ps1,
    2-CreateEndpointWithSpecificPortAndIPAddress.ps1, 3-RemoveEndpoint.ps1,
    1-AddConnectPermission.ps1, 2-RemoveConnectPermission.ps1,
    3-AddConnectPermissionToAlwaysOnPrimaryAndSecondaryReplicaEachWithDifferentSqlServiceAccounts.ps1,
    4-RemoveConnectPermissionToAlwaysOnPrimaryAndSecondaryReplicaEachWithDifferentSqlServiceAccounts.ps1,
    1-MakeSureEndpointIsStarted.ps1, 2-MakeSureEndpointIsStopped.ps1,
    1-EnableTcpIpWithStaticPort.ps1, 2-EnableTcpIpWithDynamicPort.ps1,
    1-AddServerPermissionForLogin.ps1, 2-RemoveServerPermissionForLogin.ps1,
    1-ConfigureInstanceAsDistributor.ps1, 2-ConfigureInstanceAsPublisher.ps1,
    1-WaitForASingleClusterGroup.ps1, 2-WaitForMultipleClusterGroups.ps1.
@johlju johlju added the needs review The pull request needs a code review. label Jul 22, 2017
@codecov-io
Copy link

codecov-io commented Jul 22, 2017

Codecov Report

Merging #708 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@         Coverage Diff         @@
##            dev   #708   +/-   ##
===================================
  Coverage    97%    97%           
===================================
  Files        30     30           
  Lines      3250   3250           
===================================
  Hits       3165   3165           
  Misses       85     85

@johlju
Copy link
Member Author

johlju commented Jul 24, 2017

Reviewed 31 of 31 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@johlju
Copy link
Member Author

johlju commented Jul 24, 2017

:LGTM:


Review status: :shipit: all files reviewed at latest revision, all discussions resolved, all commit checks successful.


Comments from Reviewable

@johlju johlju merged commit 7db2ffc into dsccommunity:dev Jul 24, 2017
@johlju johlju deleted the optin-script-files-common-tests branch August 13, 2017 13:19
@johlju johlju removed the needs review The pull request needs a code review. label Mar 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

xSQLServer: Opt-in for script files common tests
3 participants