SqlSetup: Fix AddNode failing due to missing setup parameters #2047
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
As documented by Microsoft, the "AddNode" action requires a value for the parameter
FailoverClusterIPAddresses
. The SqlServerDsc module was incorrectly excluding this property from the arguments passed to the setup program. This caused any DSC operations for "AddNode" to fail during theSet-TargetResource
process. This PR makes a minor adjustment to allow the IP property to be emitted when$Action
is set to "AddNode".This Pull Request (PR) fixes the following issues
Task list
file CHANGELOG.md. Entry should say what was changed and how that
affects users (if applicable), and reference the issue being resolved
(if applicable).
This change is