Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SqlSetup: Fix AddNode failing due to missing setup parameters #2047

Merged

Conversation

nabrond
Copy link
Contributor

@nabrond nabrond commented Oct 2, 2024

Pull Request (PR) description

As documented by Microsoft, the "AddNode" action requires a value for the parameter FailoverClusterIPAddresses. The SqlServerDsc module was incorrectly excluding this property from the arguments passed to the setup program. This caused any DSC operations for "AddNode" to fail during the Set-TargetResource process. This PR makes a minor adjustment to allow the IP property to be emitted when $Action is set to "AddNode".

This Pull Request (PR) fixes the following issues

Task list

  • Added an entry to the change log under the Unreleased section of the
    file CHANGELOG.md. Entry should say what was changed and how that
    affects users (if applicable), and reference the issue being resolved
    (if applicable).
  • Resource documentation updated in the resource's README.md.
  • Resource parameter descriptions updated in schema.mof.
  • Comment-based help updated, including parameter descriptions.
  • Localization strings updated.
  • Examples updated.
  • Unit tests updated. See DSC Community Testing Guidelines.
  • Integration tests updated (where possible). See DSC Community Testing Guidelines.
  • Code changes adheres to DSC Community Style Guidelines.

This change is Reviewable

@nabrond nabrond requested review from johlju and a team as code owners October 2, 2024 18:13
Copy link

codecov bot commented Oct 2, 2024

Codecov Report

Attention: Patch coverage is 87.50000% with 1 line in your changes missing coverage. Please review.

Project coverage is 94%. Comparing base (3c30929) to head (c8cbea4).
Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
source/DSCResources/DSC_SqlSetup/DSC_SqlSetup.psm1 87% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@         Coverage Diff          @@
##           main   #2047   +/-   ##
====================================
  Coverage    94%     94%           
====================================
  Files        94      94           
  Lines      7922    7930    +8     
====================================
+ Hits       7492    7500    +8     
  Misses      430     430           
Flag Coverage Δ
unit 94% <87%> (+<1%) ⬆️
Files with missing lines Coverage Δ
source/DSCResources/DSC_SqlSetup/DSC_SqlSetup.psm1 98% <87%> (+<1%) ⬆️

@johlju johlju added the needs review The pull request needs a code review. label Oct 5, 2024
Copy link
Member

@johlju johlju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @nabrond)

@johlju johlju merged commit 5677cd5 into dsccommunity:main Oct 6, 2024
37 of 40 checks passed
@johlju johlju removed the needs review The pull request needs a code review. label Oct 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SqlSetup: AddNode is not working (missing 4 parameters in commandline)
2 participants