Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix markdown highlights #1978

Merged
merged 1 commit into from
Nov 19, 2023
Merged

Fix markdown highlights #1978

merged 1 commit into from
Nov 19, 2023

Conversation

johlju
Copy link
Member

@johlju johlju commented Nov 18, 2023

Pull Request (PR) description

  • SqlServerDsc
    • Update markdown highlights with newly supported keywords.

This Pull Request (PR) fixes the following issues

None.

Task list

  • Added an entry to the change log under the Unreleased section of the
    file CHANGELOG.md. Entry should say what was changed and how that
    affects users (if applicable), and reference the issue being resolved
    (if applicable).
  • Resource documentation updated in the resource's README.md.
  • Resource parameter descriptions updated in schema.mof.
  • Comment-based help updated, including parameter descriptions.
  • Localization strings updated.
  • Examples updated.
  • Unit tests updated. See DSC Community Testing Guidelines.
  • Integration tests updated (where possible). See DSC Community Testing Guidelines.
  • Code changes adheres to DSC Community Style Guidelines.

This change is Reviewable

@johlju johlju requested a review from a team as a code owner November 18, 2023 10:08
Copy link

codecov bot commented Nov 18, 2023

Codecov Report

Merging #1978 (4f3eda4) into main (85f8523) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@         Coverage Diff          @@
##           main   #1978   +/-   ##
====================================
  Coverage    92%     92%           
====================================
  Files        93      93           
  Lines      7840    7840           
====================================
  Hits       7214    7214           
  Misses      626     626           
Flag Coverage Δ
unit 92% <ø> (ø)
Files Coverage Δ
source/Classes/020.SqlDatabasePermission.ps1 99% <ø> (ø)
source/Classes/020.SqlPermission.ps1 99% <ø> (ø)

Copy link
Member Author

@johlju johlju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 13 of 13 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @johlju)

@johlju johlju merged commit e9639fd into dsccommunity:main Nov 19, 2023
36 checks passed
@johlju johlju deleted the fix/highlights branch November 19, 2023 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant