Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SqlServerDsc: Update pipeline files from Sampler #1964

Merged
merged 6 commits into from
Aug 24, 2023

Conversation

johlju
Copy link
Member

@johlju johlju commented Aug 22, 2023

Pull Request (PR) description

  • SqlServerDsc
    • Updated pipeline files to support ModuleFast.
  • SqlRs
    • Updated examples to use xPSDesiredStateConfiguration instead of PSDScResources.
    • Updated integration tests to use xPSDesiredStateConfiguration instead of PSDScResources.
  • SqlScript
    • Updated examples to use xPSDesiredStateConfiguration instead of PSDScResources.
    • Updated integration tests to use xPSDesiredStateConfiguration instead of PSDScResources.
  • SqlScriptQuery
    • Updated examples to use xPSDesiredStateConfiguration instead of PSDScResources.
  • SqlSetup
    • Updated examples to use xPSDesiredStateConfiguration instead of PSDScResources.
    • Updated integration tests to use xPSDesiredStateConfiguration instead of PSDScResources.
  • SqlAlwaysOnService
    • Updated integration tests to use xPSDesiredStateConfiguration instead of PSDScResources.
  • SqlLogin
    • Updated integration tests to use xPSDesiredStateConfiguration instead of PSDScResources.
  • SqlReplication
    • Updated integration tests to use xPSDesiredStateConfiguration instead of PSDScResources.
  • SqlRSSetup
    • Updated integration tests to use xPSDesiredStateConfiguration instead of PSDScResources.
  • SqlServiceAccount
    • Updated integration tests to use xPSDesiredStateConfiguration instead of PSDScResources.
  • SqlWindowsFirewall
    • Updated integration tests to use xPSDesiredStateConfiguration instead of PSDScResources.

Additional change log entries should be added once I see this PR passes tests. Additional changes might be required

This Pull Request (PR) fixes the following issues

None.

Task list

  • Added an entry to the change log under the Unreleased section of the
    file CHANGELOG.md. Entry should say what was changed and how that
    affects users (if applicable), and reference the issue being resolved
    (if applicable).
  • Resource documentation updated in the resource's README.md.
  • Resource parameter descriptions updated in schema.mof.
  • Comment-based help updated, including parameter descriptions.
  • Localization strings updated.
  • Examples updated.
  • Unit tests updated. See DSC Community Testing Guidelines.
  • Integration tests updated (where possible). See DSC Community Testing Guidelines.
  • Code changes adheres to DSC Community Style Guidelines.

This change is Reviewable

@johlju johlju added the waiting for author response The pull request is waiting for the author to respond to comments in the pull request. label Aug 22, 2023
@codecov
Copy link

codecov bot commented Aug 22, 2023

Codecov Report

Merging #1964 (06195bd) into main (0402505) will not change coverage.
Report is 1 commits behind head on main.
The diff coverage is n/a.

Impacted file tree graph

@@         Coverage Diff          @@
##           main   #1964   +/-   ##
====================================
  Coverage    91%     91%           
====================================
  Files        92      92           
  Lines      7810    7810           
====================================
  Hits       7185    7185           
  Misses      625     625           
Flag Coverage Δ
unit 91% <ø> (ø)

@johlju johlju marked this pull request as ready for review August 24, 2023 03:57
Copy link
Member Author

@johlju johlju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 11 of 17 files at r1, 14 of 14 files at r2.
Reviewable status: 24 of 25 files reviewed, 1 unresolved discussion (waiting on @johlju)


CHANGELOG.md line 32 at r2 (raw file):

    Linux and macOS.
  - Highlighted note comments throughout markdown and generated markdown.
  - Updated pipeline files to support ModuleFast.

Duplicate change log entry

Copy link
Member Author

@johlju johlju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 24 of 25 files reviewed, all discussions resolved (waiting on @johlju)


CHANGELOG.md line 32 at r2 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

Duplicate change log entry

Done

Copy link
Member Author

@johlju johlju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @johlju)

@johlju johlju added needs review The pull request needs a code review. and removed waiting for author response The pull request is waiting for the author to respond to comments in the pull request. labels Aug 24, 2023
@johlju johlju merged commit 8047f7c into dsccommunity:main Aug 24, 2023
@johlju johlju deleted the f/modulefast branch August 24, 2023 10:49
@johlju johlju removed the needs review The pull request needs a code review. label Aug 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant