-
Notifications
You must be signed in to change notification settings - Fork 225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SqlSetup: Add parameter SqlVersion
#1962
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1962 +/- ##
====================================
Coverage 91% 92%
====================================
Files 92 92
Lines 7810 7829 +19
====================================
+ Hits 7185 7204 +19
Misses 625 625
|
johlju
commented
Aug 25, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 3 of 5 files at r1, 3 of 3 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @johlju)
johlju
added
ready for merge
The pull request was approved by the community and is ready to be merged by a maintainer.
and removed
needs review
The pull request needs a code review.
labels
Aug 25, 2023
johlju
removed
the
ready for merge
The pull request was approved by the community and is ready to be merged by a maintainer.
label
Aug 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
SqlVersion
that can be used to set the SQL Serverversion to be installed instead of it looking for version in the setup
executable of the SQL Server media. This parameter is not allowed for
the setup action
Upgrade
, if specified it will throw an exception(issue #1946).
This Pull Request (PR) fixes the following issues
SourcePath
too early for Puppet #1946Task list
file CHANGELOG.md. Entry should say what was changed and how that
affects users (if applicable), and reference the issue being resolved
(if applicable).
This change is