Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SqlSetup: Add parameter SqlVersion #1962

Merged
merged 8 commits into from
Aug 26, 2023
Merged

Conversation

johlju
Copy link
Member

@johlju johlju commented Aug 22, 2023

Pull Request (PR) description

  • SqlSetup
    • Added the parameter SqlVersion that can be used to set the SQL Server
      version to be installed instead of it looking for version in the setup
      executable of the SQL Server media. This parameter is not allowed for
      the setup action Upgrade, if specified it will throw an exception
      (issue #1946).

This Pull Request (PR) fixes the following issues

Task list

  • Added an entry to the change log under the Unreleased section of the
    file CHANGELOG.md. Entry should say what was changed and how that
    affects users (if applicable), and reference the issue being resolved
    (if applicable).
  • Resource documentation updated in the resource's README.md.
  • Resource parameter descriptions updated in schema.mof.
  • Comment-based help updated, including parameter descriptions.
  • Localization strings updated.
  • Examples updated.
  • Unit tests updated. See DSC Community Testing Guidelines.
  • Integration tests updated (where possible). See DSC Community Testing Guidelines.
  • Code changes adheres to DSC Community Style Guidelines.

This change is Reviewable

@johlju johlju added the needs review The pull request needs a code review. label Aug 22, 2023
@codecov
Copy link

codecov bot commented Aug 22, 2023

Codecov Report

Merging #1962 (3de67aa) into main (8047f7c) will increase coverage by 0%.
The diff coverage is 100%.

Impacted file tree graph

@@         Coverage Diff          @@
##           main   #1962   +/-   ##
====================================
  Coverage    91%     92%           
====================================
  Files        92      92           
  Lines      7810    7829   +19     
====================================
+ Hits       7185    7204   +19     
  Misses      625     625           
Flag Coverage Δ
unit 92% <100%> (+<1%) ⬆️
Files Changed Coverage Δ
source/DSCResources/DSC_SqlSetup/DSC_SqlSetup.psm1 98% <100%> (+<1%) ⬆️

Copy link
Member Author

@johlju johlju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 3 of 5 files at r1, 3 of 3 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @johlju)

@johlju johlju added ready for merge The pull request was approved by the community and is ready to be merged by a maintainer. and removed needs review The pull request needs a code review. labels Aug 25, 2023
@johlju johlju merged commit 472ef04 into dsccommunity:main Aug 26, 2023
@johlju johlju deleted the fix/issue-1946 branch August 26, 2023 07:11
@johlju johlju removed the ready for merge The pull request was approved by the community and is ready to be merged by a maintainer. label Aug 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SqlSetup: Seems to evaluate the SourcePath too early for Puppet
1 participant