Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SqlLogin: Attempting to disable and already disabled login throws an error #1952 #1953

Merged

Conversation

JoshKingWork
Copy link
Contributor

@JoshKingWork JoshKingWork commented Jul 20, 2023

Pull Request (PR) description

Changes from string Exception to just Exception object so InnerException can be searched for error codes

This Pull Request (PR) fixes the following issues

Task list

  • Added an entry to the change log under the Unreleased section of the
    file CHANGELOG.md. Entry should say what was changed and how that
    affects users (if applicable), and reference the issue being resolved
    (if applicable).
  • Resource documentation updated in the resource's README.md.
  • Resource parameter descriptions updated in schema.mof.
  • Comment-based help updated, including parameter descriptions.
  • Localization strings updated.
  • Examples updated.
  • Unit tests updated. See DSC Community Testing Guidelines.
  • Integration tests updated (where possible). See DSC Community Testing Guidelines.
  • Code changes adheres to DSC Community Style Guidelines.

This change is Reviewable

@codecov
Copy link

codecov bot commented Jul 20, 2023

Codecov Report

Merging #1953 (c8bbf70) into main (e52f4a5) will not change coverage.
The diff coverage is 50%.

Impacted file tree graph

@@         Coverage Diff          @@
##           main   #1953   +/-   ##
====================================
  Coverage    91%     91%           
====================================
  Files        92      92           
  Lines      7810    7810           
====================================
  Hits       7185    7185           
  Misses      625     625           
Flag Coverage Δ
unit 91% <50%> (ø)
Files Changed Coverage Δ
...dules/SqlServerDsc.Common/SqlServerDsc.Common.psm1 96% <50%> (ø)

@johlju johlju added the needs review The pull request needs a code review. label Aug 1, 2023
Copy link
Member

@johlju johlju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, it just need to be rebased. I can do that myself later in the day.

Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @JoshKingWork)

@johlju johlju added ready for merge The pull request was approved by the community and is ready to be merged by a maintainer. and removed needs review The pull request needs a code review. labels Aug 19, 2023
Copy link
Member

@johlju johlju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @JoshKingWork)

@johlju johlju merged commit 22c4f2d into dsccommunity:main Aug 19, 2023
@johlju johlju removed the ready for merge The pull request was approved by the community and is ready to be merged by a maintainer. label Aug 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SqlLogin: Attempting to disable and already disabled login throws an error
2 participants