Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SqlRS: Using Invoke-SqlDscQuery #1919

Merged
merged 10 commits into from
Apr 23, 2023

Conversation

johlju
Copy link
Member

@johlju johlju commented Apr 22, 2023

Pull Request (PR) description

This Pull Request (PR) fixes the following issues

Task list

  • Added an entry to the change log under the Unreleased section of the
    file CHANGELOG.md. Entry should say what was changed and how that
    affects users (if applicable), and reference the issue being resolved
    (if applicable).
  • Resource documentation updated in the resource's README.md.
  • Resource parameter descriptions updated in schema.mof.
  • Comment-based help updated, including parameter descriptions.
  • Localization strings updated.
  • Examples updated.
  • Unit tests updated. See DSC Community Testing Guidelines.
  • Integration tests updated (where possible). See DSC Community Testing Guidelines.
  • Code changes adheres to DSC Community Style Guidelines.

This change is Reviewable

@codecov
Copy link

codecov bot commented Apr 22, 2023

Codecov Report

Merging #1919 (c0f8346) into main (3e81805) will increase coverage by 0%.
The diff coverage is 100%.

Impacted file tree graph

@@         Coverage Diff          @@
##           main   #1919   +/-   ##
====================================
  Coverage    92%     92%           
====================================
  Files        91      91           
  Lines      7715    7725   +10     
====================================
+ Hits       7112    7122   +10     
  Misses      603     603           
Flag Coverage Δ
unit 92% <100%> (+<1%) ⬆️
Impacted Files Coverage Δ
source/Public/Connect-SqlDscDatabaseEngine.ps1 100% <ø> (ø)
source/DSCResources/DSC_SqlRS/DSC_SqlRS.psm1 99% <100%> (+<1%) ⬆️
...dules/SqlServerDsc.Common/SqlServerDsc.Common.psm1 98% <100%> (+<1%) ⬆️
source/Public/Invoke-SqlDscQuery.ps1 98% <100%> (+<1%) ⬆️

Copy link
Member Author

@johlju johlju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 5 files at r1, 11 of 11 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @johlju)

@johlju johlju merged commit 44c654a into dsccommunity:main Apr 23, 2023
@johlju johlju deleted the f/sqlrs-use-invoke-sqldscquery branch April 23, 2023 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant