-
Notifications
You must be signed in to change notification settings - Fork 225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SqlRS: Using Invoke-SqlDscQuery
#1919
Merged
johlju
merged 10 commits into
dsccommunity:main
from
johlju:f/sqlrs-use-invoke-sqldscquery
Apr 23, 2023
Merged
SqlRS: Using Invoke-SqlDscQuery
#1919
johlju
merged 10 commits into
dsccommunity:main
from
johlju:f/sqlrs-use-invoke-sqldscquery
Apr 23, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1919 +/- ##
====================================
Coverage 92% 92%
====================================
Files 91 91
Lines 7715 7725 +10
====================================
+ Hits 7112 7122 +10
Misses 603 603
|
johlju
commented
Apr 23, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 5 files at r1, 11 of 11 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @johlju)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
Connect-SQL
.Encrypt
.Connect-SqlDscDatabaseEngine
Encrypt
.Invoke-SqlDscQuery
Encrypt
.Invoke-SqlDscQuery
:InstanceName
always set to default value in should process messages #1918).Invoke-SqlDscQuery
instead ofInvoke-SqlCmd
(issue SqlRs: ReplaceInvoke-SqlCmd
withInvoke-SqlDscQuery
#1917).Encrypt
has changed so thatMandatory
orStrict
will turn on encryption when connecting to the database instance.
This Pull Request (PR) fixes the following issues
Invoke-SqlCmd
withInvoke-SqlDscQuery
#1917Invoke-SqlDscQuery
:InstanceName
always set to default value in should process messages #1918Task list
file CHANGELOG.md. Entry should say what was changed and how that
affects users (if applicable), and reference the issue being resolved
(if applicable).
This change is