Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invoke-SetupAction: Expand environment variables #1914

Merged
merged 2 commits into from
Apr 17, 2023

Conversation

johlju
Copy link
Member

@johlju johlju commented Apr 16, 2023

Pull Request (PR) description

  • Update private command:
    • Invoke-SetupAction was changed to expand environment variables that
      is passed as the media path.

This Pull Request (PR) fixes the following issues

None.

Task list

  • Added an entry to the change log under the Unreleased section of the
    file CHANGELOG.md. Entry should say what was changed and how that
    affects users (if applicable), and reference the issue being resolved
    (if applicable).
  • Resource documentation updated in the resource's README.md.
  • Resource parameter descriptions updated in schema.mof.
  • Comment-based help updated, including parameter descriptions.
  • Localization strings updated.
  • Examples updated.
  • Unit tests updated. See DSC Community Testing Guidelines.
  • Integration tests updated (where possible). See DSC Community Testing Guidelines.
  • Code changes adheres to DSC Community Style Guidelines.

This change is Reviewable

@codecov
Copy link

codecov bot commented Apr 16, 2023

Codecov Report

Merging #1914 (da54ca6) into main (d8e6b74) will increase coverage by 0%.
The diff coverage is 100%.

Impacted file tree graph

@@         Coverage Diff          @@
##           main   #1914   +/-   ##
====================================
  Coverage    92%     92%           
====================================
  Files        91      91           
  Lines      7714    7715    +1     
====================================
+ Hits       7111    7112    +1     
  Misses      603     603           
Flag Coverage Δ
unit 92% <100%> (+<1%) ⬆️
Impacted Files Coverage Δ
source/Private/Invoke-SetupAction.ps1 92% <100%> (+<1%) ⬆️

@johlju johlju added the needs review The pull request needs a code review. label Apr 16, 2023
Copy link
Member Author

@johlju johlju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @johlju)

@johlju johlju merged commit 3e81805 into dsccommunity:main Apr 17, 2023
@johlju johlju deleted the fix/expandMediaPath branch April 17, 2023 14:09
@johlju johlju removed the needs review The pull request needs a code review. label Apr 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant