Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SqlServerDsc: Fix how major version is bumped #1913

Merged
merged 1 commit into from
Apr 16, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 18 additions & 18 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -13,28 +13,28 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

### Added

- SqlServerDsc
- New public commands:
- `Disconnect-SqlDscDatabaseEngine` - Disconnects from a SQL Server instance
that was previously connected to using `Connect-SqlDscDatabaseEngine`.
- `Test-SqlDscIsSupportedFeature` - Evaluates if a feature is supported by a specific
Microsoft SQL Server major version. _This command must be extended with_
_a full list of when features were added and removed in each major_
_version to fully work_.
- New private commands:
- `ConvertTo-RedactedText` - Used to redact sensitive information from
text that then can be used in console output like verbose messages.
- `Get-FileVersionInformation` - Returns the version information
for a file.
- `Assert-Feature` - Throws an exception if a feature is not supported
for a specific Microsoft SQL Server major version.
- New public commands:
- `Disconnect-SqlDscDatabaseEngine` - Disconnects from a SQL Server instance
that was previously connected to using `Connect-SqlDscDatabaseEngine`.
- `Test-SqlDscIsSupportedFeature` - Evaluates if a feature is supported by a specific
Microsoft SQL Server major version. _This command must be extended with_
_a full list of when features were added and removed in each major_
_version to fully work_.
- New private commands:
- `ConvertTo-RedactedText` - Used to redact sensitive information from
text that then can be used in console output like verbose messages.
- `Get-FileVersionInformation` - Returns the version information
for a file.
- `Assert-Feature` - Throws an exception if a feature is not supported
for a specific Microsoft SQL Server major version.

### Changed

- Private functions:
- Gitversion no longer evaluates bumping major version using the word "major".
- Update private command:
- `Assert-SetupActionProperties` was changed to throw
an exception when a feature is not supported (uses `Assert-Feature`).
The private function indirectly used by the setup action commands.
an exception when a feature is not supported (calls `Assert-Feature`).
The private command is indirectly used by the setup action commands.
- SqlSetup
- Update to support checking non-supported features using the command
`SqlDscIsSupportedFeature` ([issue #1872](https://github.com/dsccommunity/SqlServerDsc/issues/1872)).
Expand Down
2 changes: 1 addition & 1 deletion GitVersion.yml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
mode: ContinuousDelivery
next-version: 13.3.0
major-version-bump-message: '(breaking\schange|breaking|major)\b'
major-version-bump-message: '(breaking\schange|breaking)\b'
minor-version-bump-message: '(adds?|minor)\b'
patch-version-bump-message: '\s?(fix|patch)'
no-bump-message: '\+semver:\s?(none|skip)'
Expand Down