Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SqlSecureConnection: Added new parameter ServerName #1892

Merged
merged 6 commits into from
Apr 1, 2023

Conversation

johlju
Copy link
Member

@johlju johlju commented Mar 28, 2023

Pull Request (PR) description

This Pull Request (PR) fixes the following issues

Task list

  • Added an entry to the change log under the Unreleased section of the
    file CHANGELOG.md. Entry should say what was changed and how that
    affects users (if applicable), and reference the issue being resolved
    (if applicable).
  • Resource documentation updated in the resource's README.md.
  • Resource parameter descriptions updated in schema.mof.
  • Comment-based help updated, including parameter descriptions.
  • Localization strings updated.
  • Examples updated.
  • Unit tests updated. See DSC Community Testing Guidelines.
  • Integration tests updated (where possible). See DSC Community Testing Guidelines.
  • Code changes adheres to DSC Community Style Guidelines.

This change is Reviewable

@johlju johlju added the needs review The pull request needs a code review. label Mar 28, 2023
@codecov
Copy link

codecov bot commented Mar 28, 2023

Codecov Report

❗ No coverage uploaded for pull request base (main@4c98dda). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff           @@
##             main   #1892   +/-   ##
======================================
  Coverage        ?     92%           
======================================
  Files           ?      85           
  Lines           ?    7641           
  Branches        ?       0           
======================================
  Hits            ?    7039           
  Misses          ?     602           
  Partials        ?       0           
Flag Coverage Δ
unit 92% <100%> (?)
Impacted Files Coverage Δ
...C_SqlSecureConnection/DSC_SqlSecureConnection.psm1 100% <100%> (ø)

Copy link
Member Author

@johlju johlju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 5 of 7 files at r1, 1 of 1 files at r2, 2 of 2 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @johlju)

@johlju johlju merged commit e7b347e into dsccommunity:main Apr 1, 2023
@johlju johlju deleted the fix/issue#1888 branch April 1, 2023 19:11
@johlju johlju removed the needs review The pull request needs a code review. label Apr 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SqlSecureConnection: Unable to finish successfully with ForcedEncryption
1 participant