SqlServerDsc: Replace Import-SQLPSModule

[johlju]

Pull Request (PR) description

• SqlServerDsc
  • The private function Import-SQLPSModule was replaced throughout with
    the public command Import-SqlDscPreferredModule (issue SqlServerDsc.Common: Replace Import-SQLPSModule with Import-SqlDscPreferredModule #1848).

This Pull Request (PR) fixes the following issues

• Fixes SqlServerDsc.Common: Replace Import-SQLPSModule with Import-SqlDscPreferredModule #1848

Task list

• Added an entry to the change log under the Unreleased section of the
  file CHANGELOG.md. Entry should say what was changed and how that
  affects users (if applicable), and reference the issue being resolved
  (if applicable).
• Resource documentation updated in the resource's README.md.
• Resource parameter descriptions updated in schema.mof.
• Comment-based help updated, including parameter descriptions.
• Localization strings updated.
• Examples updated.
• Unit tests updated. See DSC Community Testing Guidelines.
• Integration tests updated (where possible). See DSC Community Testing Guidelines.
• Code changes adheres to DSC Community Style Guidelines.

---

This change is 

[codecov]

Codecov Report

Merging #1862 (9111bef) into main (b24df85) will decrease coverage by 1%.
The diff coverage is 93%.

@@         Coverage Diff          @@
##           main   #1862   +/-   ##
====================================
- Coverage    92%     92%   -1%     
====================================
  Files        85      85           
  Lines      7608    7607    -1     
====================================
- Hits       7006    7005    -1     
  Misses      602     602           

Flag	Coverage Δ
unit	92% <93%> (-1%)	⬇️

Impacted Files	Coverage Δ
...Resources/DSC_SqlAGDatabase/DSC_SqlAGDatabase.psm1	0% <0%> (ø)
...urce/DSCResources/DSC_SqlScript/DSC_SqlScript.psm1	100% <ø> (ø)
...sources/DSC_SqlScriptQuery/DSC_SqlScriptQuery.psm1	100% <ø> (ø)
...SCResources/DSC_SqlAGReplica/DSC_SqlAGReplica.psm1	100% <100%> (ø)
...DSC_SqlAlwaysOnService/DSC_SqlAlwaysOnService.psm1	100% <100%> (ø)
.../DSCResources/DSC_SqlProtocol/DSC_SqlProtocol.psm1	100% <100%> (ø)
...ces/DSC_SqlProtocolTcpIp/DSC_SqlProtocolTcpIp.psm1	100% <100%> (ø)
source/DSCResources/DSC_SqlRS/DSC_SqlRS.psm1	99% <100%> (ø)
...sources/DSC_SqlReplication/DSC_SqlReplication.psm1	65% <100%> (ø)
...s/DSC_SqlServiceAccount/DSC_SqlServiceAccount.psm1	98% <100%> (ø)
... and 3 more

[johlju]

Reviewed 28 of 28 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion

---

source/Modules/SqlServerDsc.Common/SqlServerDsc.Common.psd1 line 35 at r1 (raw file):

        'Connect-SQLAnalysis'
        'Get-SqlInstanceMajorVersion'
        'Import-SqlDscPreferredModule'

This should not be exported.

Code quote:

'Import-SqlDscPreferredModule'

[johlju]

Reviewed all commit messages.
Reviewable status: 27 of 28 files reviewed, all discussions resolved (waiting on @johlju)

---

source/Modules/SqlServerDsc.Common/SqlServerDsc.Common.psd1 line 35 at r1 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

This should not be exported.

Done

[johlju]

Reviewed 1 of 1 files at r2.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @johlju)