Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SqlServerDsc: Change type for property Reasons #1858

Merged
merged 4 commits into from
Feb 28, 2023

Conversation

johlju
Copy link
Member

@johlju johlju commented Feb 26, 2023

Pull Request (PR) description

  • SqlServerDsc
    • Added class SqlReason to be used as the type of the DSC property Reasons
      for class-based resources.
    • The type of the property Reasons was changed in the class-based resources.
      This resolves a problem when using two DSC resource modules that was
      using the same class-type for the property Reasons.
  • SqlAudit
    • Return the correct type for parameter LogType when calling method Get().

This Pull Request (PR) fixes the following issues

Task list

  • Added an entry to the change log under the Unreleased section of the
    file CHANGELOG.md. Entry should say what was changed and how that
    affects users (if applicable), and reference the issue being resolved
    (if applicable).
  • Resource documentation updated in the resource's README.md.
  • Resource parameter descriptions updated in schema.mof.
  • Comment-based help updated, including parameter descriptions.
  • Localization strings updated.
  • Examples updated.
  • Unit tests updated. See DSC Community Testing Guidelines.
  • Integration tests updated (where possible). See DSC Community Testing Guidelines.
  • Code changes adheres to DSC Community Style Guidelines.

This change is Reviewable

@codecov
Copy link

codecov bot commented Feb 26, 2023

Codecov Report

Merging #1858 (c6b7d8d) into main (f6ce795) will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@         Coverage Diff          @@
##           main   #1858   +/-   ##
====================================
  Coverage    92%     92%           
====================================
  Files        85      85           
  Lines      7608    7608           
====================================
  Hits       7006    7006           
  Misses      602     602           
Flag Coverage Δ
unit 92% <100%> (ø)
Impacted Files Coverage Δ
source/Classes/011.SqlResourceBase.ps1 83% <ø> (ø)
source/Classes/020.SqlAudit.ps1 99% <100%> (ø)

@johlju johlju force-pushed the fix/class-based-resource-Reasons branch from cc10bf2 to 2f84e7c Compare February 27, 2023 16:17
@johlju johlju added the needs review The pull request needs a code review. label Feb 28, 2023
Copy link
Member Author

@johlju johlju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 5 of 5 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @johlju)

@johlju johlju merged commit b24df85 into dsccommunity:main Feb 28, 2023
@johlju johlju deleted the fix/class-based-resource-Reasons branch February 28, 2023 15:07
@johlju johlju removed the needs review The pull request needs a code review. label Feb 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment