-
Notifications
You must be signed in to change notification settings - Fork 225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SqlAGReplica: Run Update-AvailabilityGroupReplica Once for All AvailabilityReplica Changes #1840
Conversation
[skip ci]
…ingle update at end. Updated testing to ensure only one update occurs when the AvailabilityMode and FailoverMode changes at the same time
… Updated tests for AGReplica to reflect update only needing to run once regardless of how many changes
…itivity with linux
…FailoverMode to trigger 1 update at the same time.
Codecov Report
@@ Coverage Diff @@
## main #1840 +/- ##
====================================
Coverage 91% 91%
====================================
Files 71 71
Lines 7310 7313 +3
====================================
+ Hits 6661 6664 +3
Misses 649 649
|
@hollanjs awesome work! Looks great at initial glance. Will review later today. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 5 of 5 files at r2, 2 of 2 files at r3, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @hollanjs)
Pull Request (PR) description
This PR alters how the
SqlAGReplica
changes properties of the AvailabilityReplica. Rather than triggering an update for each individual property that is out of state,Update-AvailabilityGroupReplica
now triggers only once at the end, applying all property updates at once.To specifically resolve issues with
FailoverMode
andAvailabilityMode
updates:FailoverMode
checks were moved up beforeAvailabilityMode
checksFailoverMode
andAvailabilityMode
are always updated at the same time. This should hopefully ensure future changes do not cause this issue to come back.This Pull Request (PR) fixes the following issues
Task list
file CHANGELOG.md. Entry should say what was changed and how that
affects users (if applicable), and reference the issue being resolved
(if applicable).
This change is