-
Notifications
You must be signed in to change notification settings - Fork 225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SqlAGListener: Add parameter ProcessOnlyOnActiveNode
to make it cluster aware
#1783
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1783 +/- ##
====================================
Coverage 92% 92%
====================================
Files 93 93
Lines 7832 7840 +8
====================================
+ Hits 7206 7214 +8
Misses 626 626
|
@dlenkov can you please update the unit tests so they pass with this change. You might take look at the unit test for another resource that have implemented the same. |
Labeling this pull request (PR) as abandoned since it has gone 14 days or more since the last update. An abandoned PR can be continued by another contributor. The abandoned label will be removed if work on this PR is taken up again. |
Labeling this pull request (PR) as abandoned since it has gone 14 days or more since the last update. An abandoned PR can be continued by another contributor. The abandoned label will be removed if work on this PR is taken up again. |
Labeling this pull request (PR) as abandoned since it has gone 14 days or more since the last update. An abandoned PR can be continued by another contributor. The abandoned label will be removed if work on this PR is taken up again. |
ProcessOnlyOnActiveNode
to make it cluster aware
57b32b6
to
c6f6283
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 6 of 7 files at r1, 2 of 2 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @dlenkov)
Pull Request (PR) description
the resource will only determine if a change is needed if the target node
is the active host of the SQL Server instance (issue #871).
This Pull Request (PR) fixes the following issues
Task list
file CHANGELOG.md. Entry should say what was changed and how that
affects users (if applicable), and reference the issue being resolved
(if applicable).
This change is