Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SqlAGListener: Add parameter ProcessOnlyOnActiveNode to make it cluster aware #1783

Merged
merged 4 commits into from
Sep 30, 2023

Conversation

dlenkov
Copy link
Contributor

@dlenkov dlenkov commented Aug 29, 2022

Pull Request (PR) description

  • Changes to SqlAGListener
    • Made the resource cluster aware. When ProcessOnlyOnActiveNode is specified,
      the resource will only determine if a change is needed if the target node
      is the active host of the SQL Server instance (issue #871).

This Pull Request (PR) fixes the following issues

Task list

  • Added an entry to the change log under the Unreleased section of the
    file CHANGELOG.md. Entry should say what was changed and how that
    affects users (if applicable), and reference the issue being resolved
    (if applicable).
  • Resource documentation updated in the resource's README.md.
  • Resource parameter descriptions updated in schema.mof.
  • Comment-based help updated, including parameter descriptions.
  • Localization strings updated.
  • Examples updated.
  • Unit tests updated. See DSC Community Testing Guidelines.
  • Integration tests updated (where possible). See DSC Community Testing Guidelines.
  • Code changes adheres to DSC Community Style Guidelines.

This change is Reviewable

@codecov
Copy link

codecov bot commented Aug 29, 2022

Codecov Report

Merging #1783 (c6f6283) into main (2fe45da) will increase coverage by 0%.
The diff coverage is 100%.

Impacted file tree graph

@@         Coverage Diff          @@
##           main   #1783   +/-   ##
====================================
  Coverage    92%     92%           
====================================
  Files        93      93           
  Lines      7832    7840    +8     
====================================
+ Hits       7206    7214    +8     
  Misses      626     626           
Flag Coverage Δ
unit 92% <100%> (+<1%) ⬆️
Files Coverage Δ
...Resources/DSC_SqlAGListener/DSC_SqlAGListener.psm1 98% <100%> (+<1%) ⬆️

@johlju johlju added the needs review The pull request needs a code review. label Aug 30, 2022
@johlju
Copy link
Member

johlju commented Aug 30, 2022

@dlenkov can you please update the unit tests so they pass with this change. You might take look at the unit test for another resource that have implemented the same.

@johlju johlju added waiting for code fix A review left open comments, and the pull request is waiting for changes to be pushed by the author. and removed needs review The pull request needs a code review. labels Aug 30, 2022
@github-actions
Copy link

Labeling this pull request (PR) as abandoned since it has gone 14 days or more since the last update. An abandoned PR can be continued by another contributor. The abandoned label will be removed if work on this PR is taken up again.

@github-actions github-actions bot added abandoned The pull request has been abandoned. and removed abandoned The pull request has been abandoned. labels Sep 15, 2022
@github-actions
Copy link

Labeling this pull request (PR) as abandoned since it has gone 14 days or more since the last update. An abandoned PR can be continued by another contributor. The abandoned label will be removed if work on this PR is taken up again.

@github-actions github-actions bot added the abandoned The pull request has been abandoned. label Sep 30, 2022
@github-actions github-actions bot removed the abandoned The pull request has been abandoned. label Mar 27, 2023
@github-actions
Copy link

Labeling this pull request (PR) as abandoned since it has gone 14 days or more since the last update. An abandoned PR can be continued by another contributor. The abandoned label will be removed if work on this PR is taken up again.

@github-actions github-actions bot added the abandoned The pull request has been abandoned. label Apr 11, 2023
@johlju johlju changed the title Fixes Issue dsccommunity#871 SqlAGListener: Add parameter ProcessOnlyOnActiveNode to make it cluster aware Sep 30, 2023
@johlju johlju force-pushed the test-fix-issue-#871 branch from 57b32b6 to c6f6283 Compare September 30, 2023 12:10
@johlju johlju requested review from johlju and a team as code owners September 30, 2023 12:10
@johlju johlju added needs review The pull request needs a code review. and removed abandoned The pull request has been abandoned. waiting for code fix A review left open comments, and the pull request is waiting for changes to be pushed by the author. labels Sep 30, 2023
Copy link
Member

@johlju johlju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 6 of 7 files at r1, 2 of 2 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @dlenkov)

@johlju johlju merged commit 350c705 into dsccommunity:main Sep 30, 2023
34 checks passed
@johlju johlju removed the needs review The pull request needs a code review. label Sep 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SqlAGListener: Should Be Cluster Aware
2 participants