-
Notifications
You must be signed in to change notification settings - Fork 225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SqlPermission: Permission parameter should be mandatory #1762
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1762 +/- ##
====================================
Coverage 87% 87%
====================================
Files 38 38
Lines 6349 6349
====================================
Hits 5575 5575
Misses 774 774
|
That PR changes SqlAG and not SqlPermission (as discussed in issue #1761) - could you please take a look at the PR again? |
Reverted previous change. Updated correct resource. Committed and squashed to clean up. |
@johlju - Please kindly take a look at this one again when you have some time please? Thanks |
I'm waiting for the build workers to get the Windows patch for DSC so the integration tests can run. I will review then. |
/AzurePipelines run |
Azure Pipelines successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 3 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @wahid99)
Pull Request (PR) description
Permission parameter within SqlPermission should be mandatory, otherwise get-targetresource throws an exception.
This Pull Request (PR) fixes the following issues
Task list
file CHANGELOG.md. Entry should say what was changed and how that
affects users (if applicable), and reference the issue being resolved
(if applicable).
This change is