Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SqlPermission: Permission parameter should be mandatory #1762

Merged
merged 2 commits into from
Jul 28, 2022

Conversation

wahid99
Copy link
Contributor

@wahid99 wahid99 commented Jun 24, 2022

Pull Request (PR) description

Permission parameter within SqlPermission should be mandatory, otherwise get-targetresource throws an exception.

This Pull Request (PR) fixes the following issues

Task list

  • Added an entry to the change log under the Unreleased section of the
    file CHANGELOG.md. Entry should say what was changed and how that
    affects users (if applicable), and reference the issue being resolved
    (if applicable).
  • Resource documentation updated in the resource's README.md.
  • Resource parameter descriptions updated in schema.mof.
  • Comment-based help updated, including parameter descriptions.
  • Localization strings updated.
  • Examples updated.
  • Unit tests updated. See DSC Community Testing Guidelines.
  • Integration tests updated (where possible). See DSC Community Testing Guidelines.
  • Code changes adheres to DSC Community Style Guidelines.

This change is Reviewable

@codecov
Copy link

codecov bot commented Jun 24, 2022

Codecov Report

Merging #1762 (8a2061d) into main (eb65b8f) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@         Coverage Diff          @@
##           main   #1762   +/-   ##
====================================
  Coverage    87%     87%           
====================================
  Files        38      38           
  Lines      6349    6349           
====================================
  Hits       5575    5575           
  Misses      774     774           
Flag Coverage Δ
unit 87% <ø> (ø)
Impacted Files Coverage Δ
...Resources/DSC_SqlPermission/DSC_SqlPermission.psm1 100% <ø> (ø)

@johlju
Copy link
Member

johlju commented Jun 24, 2022

That PR changes SqlAG and not SqlPermission (as discussed in issue #1761) - could you please take a look at the PR again?

@johlju johlju added the waiting for code fix A review left open comments, and the pull request is waiting for changes to be pushed by the author. label Jun 24, 2022
@wahid99 wahid99 changed the title Wa sql ag SqlPermission: Permission parameter should be mandatory Jul 4, 2022
@wahid99
Copy link
Contributor Author

wahid99 commented Jul 4, 2022

Reverted previous change. Updated correct resource. Committed and squashed to clean up.

@wahid99
Copy link
Contributor Author

wahid99 commented Jul 8, 2022

@johlju - Please kindly take a look at this one again when you have some time please? Thanks

@johlju
Copy link
Member

johlju commented Jul 19, 2022

I'm waiting for the build workers to get the Windows patch for DSC so the integration tests can run. I will review then.

@johlju
Copy link
Member

johlju commented Jul 27, 2022

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@johlju johlju added needs review The pull request needs a code review. and removed waiting for code fix A review left open comments, and the pull request is waiting for changes to be pushed by the author. labels Jul 28, 2022
Copy link
Member

@johlju johlju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 3 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @wahid99)

@johlju johlju added ready for merge The pull request was approved by the community and is ready to be merged by a maintainer. and removed needs review The pull request needs a code review. labels Jul 28, 2022
@johlju johlju merged commit 5b0a7e3 into dsccommunity:main Jul 28, 2022
@johlju johlju removed the ready for merge The pull request was approved by the community and is ready to be merged by a maintainer. label Jul 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SqlPermission: Get-TargetResource expects a mandatory parameter
3 participants