BREAKING CHANGE: SQLAlwaysOnService: Get-TargetResource should return Ensure=Absent

[jrdbarnes]

Pull Request (PR) description

Remove IsHadrEnabled and return the state in Ensure.
Update Test-TargetResource to look at Ensure instead of IsHadrEnabled.
Update Tests to match.

This Pull Request (PR) fixes the following issues

• Fixes BREAKING CHANGE: SQLAlwaysOnService: Get-TargetResource should return Ensure=Absent #1759

Task list

• Added an entry to the change log under the Unreleased section of the
  file CHANGELOG.md. Entry should say what was changed and how that
  affects users (if applicable), and reference the issue being resolved
  (if applicable).
• Resource documentation updated in the resource's README.md.
• Resource parameter descriptions updated in schema.mof.
• Comment-based help updated, including parameter descriptions.
• Localization strings updated.
• Examples updated.
• Unit tests updated. See DSC Community Testing Guidelines.
• Integration tests updated (where possible). See DSC Community Testing Guidelines.
• Code changes adheres to DSC Community Style Guidelines.

---

This change is 

[codecov]

Codecov Report

Merging #1760 (5f228c9) into main (c71947e) will increase coverage by 0%.
The diff coverage is 100%.

@@         Coverage Diff          @@
##           main   #1760   +/-   ##
====================================
  Coverage    87%     87%           
====================================
  Files        38      38           
  Lines      6348    6349    +1     
====================================
+ Hits       5574    5575    +1     
  Misses      774     774           

Flag	Coverage Δ
unit	87% <100%> (+<1%)	⬆️

Impacted Files	Coverage Δ
...DSC_SqlAlwaysOnService/DSC_SqlAlwaysOnService.psm1	100% <100%> (ø)

[jrdbarnes]

I'm not entirely sure on the Tests so may need some help. The integration tests were labelled skip, but seem to have run anyway?

[johlju]

There is a issue with a Windows patch that has broken credential decryption in LCM, so integration tests will fail until Microsoft releases a fix.

[johlju]

I will review tomorrow or this weekend. 🙂

[johlju]

I'm waiting for the build workers to get the Windows patch for DSC so the integration tests can run. I will review then.

[johlju]

/AzurePipelines run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[johlju]

Reviewed 5 of 5 files at r1, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @jrdbarnes)

[johlju]

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @jrdbarnes)