Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more analyzer rules #1757

Merged
merged 3 commits into from
Jun 14, 2022
Merged

Conversation

johlju
Copy link
Member

@johlju johlju commented Jun 14, 2022

Pull Request (PR) description

  • SqlServerDsc
    • Added new Script Analyzer rules from the module Indented.ScriptAnalyzerRules
      to help development and review process. The rules that did not contradict
      the existing DSC Community rules and style guideline were added.
    • Added the Visual Studio Code extension Code Spell Checker to the list
      of recommended Visual Studio Code extensions.

This Pull Request (PR) fixes the following issues

None.

Task list

  • Added an entry to the change log under the Unreleased section of the
    file CHANGELOG.md. Entry should say what was changed and how that
    affects users (if applicable), and reference the issue being resolved
    (if applicable).
  • Resource documentation updated in the resource's README.md.
  • Resource parameter descriptions updated in schema.mof.
  • Comment-based help updated, including parameter descriptions.
  • Localization strings updated.
  • Examples updated.
  • Unit tests updated. See DSC Community Testing Guidelines.
  • Integration tests updated (where possible). See DSC Community Testing Guidelines.
  • Code changes adheres to DSC Community Style Guidelines.

This change is Reviewable

@codecov
Copy link

codecov bot commented Jun 14, 2022

Codecov Report

Merging #1757 (157cc20) into main (344ac44) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@         Coverage Diff          @@
##           main   #1757   +/-   ##
====================================
  Coverage    87%     87%           
====================================
  Files        38      38           
  Lines      6348    6348           
====================================
  Hits       5574    5574           
  Misses      774     774           
Flag Coverage Δ
unit 87% <ø> (ø)
Impacted Files Coverage Δ
source/DSCResources/DSC_SqlAG/DSC_SqlAG.psm1 0% <ø> (ø)
...Resources/DSC_SqlAGDatabase/DSC_SqlAGDatabase.psm1 0% <ø> (ø)
...Resources/DSC_SqlAGListener/DSC_SqlAGListener.psm1 98% <ø> (ø)
...SCResources/DSC_SqlAGReplica/DSC_SqlAGReplica.psm1 0% <ø> (ø)
...Resources/DSC_SqlAgentAlert/DSC_SqlAgentAlert.psm1 100% <ø> (ø)
...ces/DSC_SqlAgentFailsafe/DSC_SqlAgentFailsafe.psm1 100% <ø> (ø)
...ces/DSC_SqlAgentOperator/DSC_SqlAgentOperator.psm1 100% <ø> (ø)
source/DSCResources/DSC_SqlAlias/DSC_SqlAlias.psm1 100% <ø> (ø)
...DSC_SqlAlwaysOnService/DSC_SqlAlwaysOnService.psm1 100% <ø> (ø)
...ces/DSC_SqlConfiguration/DSC_SqlConfiguration.psm1 100% <ø> (ø)
... and 27 more

Copy link
Member Author

@johlju johlju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 47 of 49 files at r1, 2 of 2 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @johlju)

@johlju johlju merged commit c71947e into dsccommunity:main Jun 14, 2022
@johlju johlju deleted the fix/more-analyzer-rules branch June 14, 2022 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant