Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SqlSetup: SourcePath should be a mandatory parameter #1756

Merged
merged 1 commit into from
Jun 8, 2022

Conversation

jrdbarnes
Copy link
Contributor

@jrdbarnes jrdbarnes commented Jun 8, 2022

Pull Request (PR) description

SourcePath should be a mandatory parameter on the *-TargetResource
functions, as an exception is thrown if the parameter is not passed.

This Pull Request (PR) fixes the following issues

Task list

  • Added an entry to the change log under the Unreleased section of the
    file CHANGELOG.md. Entry should say what was changed and how that
    affects users (if applicable), and reference the issue being resolved
    (if applicable).
  • Resource documentation updated in the resource's README.md.
  • Resource parameter descriptions updated in schema.mof.
  • Comment-based help updated, including parameter descriptions.
  • Localization strings updated.
  • Examples updated.
  • Unit tests updated. See DSC Community Testing Guidelines.
  • Integration tests updated (where possible). See DSC Community Testing Guidelines.
  • Code changes adheres to DSC Community Style Guidelines.

This change is Reviewable

SourcePath should be a mandatory parameter on the *-TargetResource
functions, as an exception is thrown if the parameter is not passed.
@codecov
Copy link

codecov bot commented Jun 8, 2022

Codecov Report

Merging #1756 (3e2daef) into main (d6eebb5) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@         Coverage Diff          @@
##           main   #1756   +/-   ##
====================================
  Coverage    87%     87%           
====================================
  Files        38      38           
  Lines      6348    6348           
====================================
  Hits       5574    5574           
  Misses      774     774           
Flag Coverage Δ
unit 87% <ø> (ø)
Impacted Files Coverage Δ
source/DSCResources/DSC_SqlSetup/DSC_SqlSetup.psm1 98% <ø> (ø)

Copy link
Member

@johlju johlju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @jrdbarnes)

@johlju johlju merged commit 344ac44 into dsccommunity:main Jun 8, 2022
@jrdbarnes jrdbarnes deleted the #1755-SqlSetup-SourcePath branch June 8, 2022 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SqlSetup: SourcePath should be a mandatory parameter
2 participants