Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SqlRs: Integration test configures SSRS 2019 #1719

Merged
merged 12 commits into from
Sep 1, 2021

Conversation

johlju
Copy link
Member

@johlju johlju commented Aug 28, 2021

Pull Request (PR) description

  • SqlRS
    • Integration tests now configures Microsoft SQL Server 2019 Reporting Services.
    • Fixed SSRS 2019 initialization (issue #1509).
    • Fix a problem that did not correctly evaluate the UseSSL property against
      the current state.

This Pull Request (PR) fixes the following issues

Task list

  • Added an entry to the change log under the Unreleased section of the
    file CHANGELOG.md. Entry should say what was changed and how that
    affects users (if applicable), and reference the issue being resolved
    (if applicable).
  • Resource documentation updated in the resource's README.md.
  • Resource parameter descriptions updated in schema.mof.
  • Comment-based help updated, including parameter descriptions.
  • Localization strings updated.
  • Examples updated.
  • Unit tests updated. See DSC Community Testing Guidelines.
  • Integration tests updated (where possible). See DSC Community Testing Guidelines.
  • Code changes adheres to DSC Community Style Guidelines.

This change is Reviewable

@johlju johlju changed the title SqlRSSetup: Installing SSRS 2019 in integration test SqlRs: Integration test configures SSRS 2019 Aug 28, 2021
@johlju johlju added the waiting for author response The pull request is waiting for the author to respond to comments in the pull request. label Aug 28, 2021
@codecov
Copy link

codecov bot commented Aug 28, 2021

Codecov Report

Merging #1719 (bd2f8ae) into main (2bc90f3) will increase coverage by 0%.
The diff coverage is 100%.

Impacted file tree graph

@@         Coverage Diff          @@
##           main   #1719   +/-   ##
====================================
  Coverage    97%     97%           
====================================
  Files        38      38           
  Lines      6325    6331    +6     
====================================
+ Hits       6169    6175    +6     
  Misses      156     156           
Flag Coverage Δ
unit 97% <100%> (+<1%) ⬆️
Impacted Files Coverage Δ
source/DSCResources/DSC_SqlRS/DSC_SqlRS.psm1 100% <100%> (ø)

@johlju johlju force-pushed the fix/sqlrs-2019-integration-test branch 2 times, most recently from 4c7c03f to 5d32949 Compare August 30, 2021 08:49
@johlju johlju marked this pull request as ready for review August 30, 2021 09:00
@johlju johlju added needs review The pull request needs a code review. and removed waiting for author response The pull request is waiting for the author to respond to comments in the pull request. labels Aug 30, 2021
Copy link
Member Author

@johlju johlju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 9 files reviewed, 1 unresolved discussion (waiting on @johlju)


source/DSCResources/DSC_SqlRS/DSC_SqlRS.psm1, line 474 at r1 (raw file):

if ($reportingServicesData.SqlVersion -ge 15)

This might not be needed according to #1698 (comment).

@johlju johlju force-pushed the fix/sqlrs-2019-integration-test branch from 97d3ab8 to bd2f8ae Compare August 31, 2021 10:56
Copy link
Member Author

@johlju johlju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 9 files reviewed, 1 unresolved discussion (waiting on @johlju)


source/DSCResources/DSC_SqlRS/DSC_SqlRS.psm1, line 474 at r1 (raw file):

Previously, johlju (Johan Ljunggren) wrote…
if ($reportingServicesData.SqlVersion -ge 15)

This might not be needed according to #1698 (comment).

Changing to the same behavior for SSRS 2017 and below can be considered a breaking change so I hold off on doing that, and instead create an issue to track this once this is merged so that I can reference the code.

Copy link
Member Author

@johlju johlju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 7 of 9 files at r1, 2 of 2 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @johlju)

@johlju johlju merged commit 82db5c7 into dsccommunity:main Sep 1, 2021
@johlju johlju deleted the fix/sqlrs-2019-integration-test branch September 1, 2021 06:31
@johlju johlju removed the needs review The pull request needs a code review. label Sep 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SqlRs: Reporting Services 2019 Configuration SQLRS Error
1 participant