-
Notifications
You must be signed in to change notification settings - Fork 225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SqlRs: Integration test configures SSRS 2019 #1719
SqlRs: Integration test configures SSRS 2019 #1719
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1719 +/- ##
====================================
Coverage 97% 97%
====================================
Files 38 38
Lines 6325 6331 +6
====================================
+ Hits 6169 6175 +6
Misses 156 156
|
4c7c03f
to
5d32949
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 9 files reviewed, 1 unresolved discussion (waiting on @johlju)
source/DSCResources/DSC_SqlRS/DSC_SqlRS.psm1, line 474 at r1 (raw file):
if ($reportingServicesData.SqlVersion -ge 15)
This might not be needed according to #1698 (comment).
97d3ab8
to
bd2f8ae
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 9 files reviewed, 1 unresolved discussion (waiting on @johlju)
source/DSCResources/DSC_SqlRS/DSC_SqlRS.psm1, line 474 at r1 (raw file):
Previously, johlju (Johan Ljunggren) wrote…
if ($reportingServicesData.SqlVersion -ge 15)
This might not be needed according to #1698 (comment).
Changing to the same behavior for SSRS 2017 and below can be considered a breaking change so I hold off on doing that, and instead create an issue to track this once this is merged so that I can reference the code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 7 of 9 files at r1, 2 of 2 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @johlju)
Pull Request (PR) description
UseSSL
property againstthe current state.
This Pull Request (PR) fixes the following issues
Task list
file CHANGELOG.md. Entry should say what was changed and how that
affects users (if applicable), and reference the issue being resolved
(if applicable).
This change is