Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SqlServerDsc: Latest pipeline files and GitHub templates #1711

Merged
merged 2 commits into from
Aug 1, 2021

Conversation

johlju
Copy link
Member

@johlju johlju commented Aug 1, 2021

Pull Request (PR) description

  • SqlServerDsc
    • Updated pipelines files to latest from Sampler project.
    • Updated GitHub issue templates.

This Pull Request (PR) fixes the following issues

None.

Task list

  • Added an entry to the change log under the Unreleased section of the
    file CHANGELOG.md. Entry should say what was changed and how that
    affects users (if applicable), and reference the issue being resolved
    (if applicable).
  • Resource documentation updated in the resource's README.md.
  • Resource parameter descriptions updated in schema.mof.
  • Comment-based help updated, including parameter descriptions.
  • Localization strings updated.
  • Examples updated.
  • Unit tests updated. See DSC Community Testing Guidelines.
  • Integration tests updated (where possible). See DSC Community Testing Guidelines.
  • Code changes adheres to DSC Community Style Guidelines.

This change is Reviewable

@johlju johlju added the needs review The pull request needs a code review. label Aug 1, 2021
Copy link
Member Author

@johlju johlju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 16 of 16 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @johlju)

@codecov
Copy link

codecov bot commented Aug 1, 2021

Codecov Report

Merging #1711 (93e6b6a) into main (ddc86c3) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@         Coverage Diff          @@
##           main   #1711   +/-   ##
====================================
  Coverage    97%     97%           
====================================
  Files        38      38           
  Lines      6325    6325           
====================================
  Hits       6169    6169           
  Misses      156     156           
Flag Coverage Δ
unit 97% <ø> (ø)

@johlju johlju merged commit 96edad6 into dsccommunity:main Aug 1, 2021
@johlju johlju deleted the fix/github-templates branch August 1, 2021 15:38
@johlju johlju removed the needs review The pull request needs a code review. label Aug 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant