Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SqlSetup: Fix integration test #1705

Merged
merged 1 commit into from
Jun 5, 2021
Merged

Conversation

johlju
Copy link
Member

@johlju johlju commented Jun 5, 2021

Pull Request (PR) description

  • SqlSetup
    • Fixed integration tests for SQL Server 2016 and SQL Server 2017.

This Pull Request (PR) fixes the following issues

None.

Task list

  • Added an entry to the change log under the Unreleased section of the
    file CHANGELOG.md. Entry should say what was changed and how that
    affects users (if applicable), and reference the issue being resolved
    (if applicable).
  • Resource documentation updated in the resource's README.md.
  • Resource parameter descriptions updated in schema.mof.
  • Comment-based help updated, including parameter descriptions.
  • Localization strings updated.
  • Examples updated.
  • Unit tests updated. See DSC Community Testing Guidelines.
  • Integration tests updated (where possible). See DSC Community Testing Guidelines.
  • Code changes adheres to DSC Community Style Guidelines.

This change is Reviewable

@johlju johlju added the needs review The pull request needs a code review. label Jun 5, 2021
@codecov
Copy link

codecov bot commented Jun 5, 2021

Codecov Report

❗ No coverage uploaded for pull request base (main@9d9143b). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##             main   #1705   +/-   ##
======================================
  Coverage        ?     97%           
======================================
  Files           ?      38           
  Lines           ?    6325           
  Branches        ?       0           
======================================
  Hits            ?    6169           
  Misses          ?     156           
  Partials        ?       0           
Flag Coverage Δ
unit 97% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

@johlju johlju merged commit 48ecbd9 into dsccommunity:main Jun 5, 2021
@johlju johlju deleted the fix/pipeline-2021 branch June 5, 2021 18:59
@johlju johlju removed the needs review The pull request needs a code review. label Aug 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant