SqlMemory: Allow setting of dynamic value for min server memory #1397 #1695
Conversation
…sccommunity#1692) - SqlSetup - The helper function `Connect-SqlAnalysis` was using `LoadWithPartial()` to load the assembly _Microsoft.AnalysisServices_. On a node where multiple instances with different versions of SQL Server (regardless of features) is installed, this will result in the first assembly found in the GAC will be loaded into the session, not taking versions into account. This can result in an assembly version being loaded that is not compatible with the version of SQL Server it was meant to be used with. A new method of loading the assembly _Microsoft.AnalysisServices_ was introduced under a feature flag; `'AnalysisServicesConnection'`. This new functionality depends on the [SqlServer](https://www.powershellgallery.com/packages/SqlServer) module, and must be present on the node. The [SqlServer](https://www.powershellgallery.com/packages/SqlServer) module can be installed on the node by leveraging the new DSC resource `PSModule` in the [PowerShellGet](https://www.powershellgallery.com/packages/PowerShellGet/2.1.2) module (v2.1.2 and higher). This new method does not work with the SQLPS module due to the SQLPS module does not load the correct assembly, while [SqlServer](https://www.powershellgallery.com/packages/SqlServer) module (v21.1.18080 and above) does. The new functionality is used when the parameter `FeatureFlag` is set to `'AnalysisServicesConnection'`. This functionality will be the default in a future breaking release. - Under a feature flag; `'AnalysisServicesConnection'`. The detection of a successful connection to the SQL Server Analysis Services has also been changed. Now it actually evaluates the property `Connected` of the returned `Microsoft.AnalysisServices.Server` object. The new functionality is used when the parameter `FeatureFlag` is set to `'AnalysisServicesConnection'`. This functionality will be the default in a future breaking release.
…Get-SqlDscPercentMemory
Codecov Report
@@ Coverage Diff @@
## main #1695 +/- ##
====================================
Coverage 97% 97%
====================================
Files 38 38
Lines 6285 6325 +40
====================================
+ Hits 6129 6169 +40
Misses 156 156
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
I will review this as soon as I can. There is a lot at the day job and also have a backlog of reviews. But this is on the todo list. 🙂 |
|
@johlju Not to worry, I completely understand. Thank you for the update and I look forward to your review and feedback :) |
|
This is still on the todo list. Just a lot of work getting DnsServerDsc out the door. I will swing back here soon. I will try to get to the backlog of all reviews during Easter. |
There was a problem hiding this comment.
Reviewed 8 of 8 files at r1.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @TrisBits)
There was a problem hiding this comment.
Reviewed 1 of 1 files at r2.
Reviewable status:
johlju
added
ready for merge
|
@TrisBits sorry it took so long - been working on tooling and other modules for a while. This looks great! Awesome work on the tests! 😃 |
johlju
changed the title
|
@johlju Thank you for the code review and feedback. Not to worry about the delay, you have a lot on your plate. |
johlju
removed
the
ready for merge
Pull Request (PR) description
Provides the ability to set the minimum and/or maximum buffer pool used by
the SQL Server instance as a percentage of total server memory (issue SqlMemory: Allow setting of dynamic value for min server memory. #1397).
This Pull Request (PR) fixes the following issues
Task list
file CHANGELOG.md. Entry should say what was changed and how that
affects users (if applicable), and reference the issue being resolved
(if applicable).
This change is