-
Notifications
You must be signed in to change notification settings - Fork 225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SqlTraceFlag: Fix for #1688 #1689
Conversation
Style guideline fixes and move change log entries
…all test for this.
Codecov Report
@@ Coverage Diff @@
## main #1689 +/- ##
====================================
Coverage 97% 97%
====================================
Files 38 38
Lines 6268 6276 +8
====================================
+ Hits 6112 6120 +8
Misses 156 156
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 10 files at r4, 2 of 2 files at r5.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @Fiander)
euh? i dont see any action to do? |
@Fiander I was looking if I could rebase this myself. But I couldn't find a easy way :/ thought I spare you the job. 😄 Could you please rebase this PR against main. So that the CHANGELOG.md is correct, currently it proposes to remove a part of the existing CHANGELOG. |
oke, wil do |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r6.
Reviewable status: complete! all files reviewed, all discussions resolved
Damm you are quick :-) did not even have time to give you a heads up |
Haha I was actually in Reviewable and saw it was missing a header, and when I was about to comment on it Reviewable refreshed for the new commit you pushes and the header was there 😂 |
Will probably merge tomorrow because I’m probably in bed when the finishes 😃 |
😲 you sleep? I don't have time for that. |
@Fiander haha I have noticed the mind works better after some sleep 😉 |
Pull Request (PR) description
Added two empty arrays so the compare object never sees a $nul
This Pull Request (PR) fixes the following issues
Task list
file CHANGELOG.md. Entry should say what was changed and how that
affects users (if applicable), and reference the issue being resolved
(if applicable).
This change is