Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SqlTraceFlag: Fix for #1688 #1689

Merged
merged 31 commits into from
Feb 12, 2021
Merged

SqlTraceFlag: Fix for #1688 #1689

merged 31 commits into from
Feb 12, 2021

Conversation

Fiander
Copy link
Contributor

@Fiander Fiander commented Feb 10, 2021

Pull Request (PR) description

Added two empty arrays so the compare object never sees a $nul

This Pull Request (PR) fixes the following issues

Task list

  • [x ] Added an entry to the change log under the Unreleased section of the
    file CHANGELOG.md. Entry should say what was changed and how that
    affects users (if applicable), and reference the issue being resolved
    (if applicable).
  • Resource documentation updated in the resource's README.md.
  • Resource parameter descriptions updated in schema.mof.
  • Comment-based help updated, including parameter descriptions.
  • Localization strings updated.
  • Examples updated.
  • Unit tests updated. See DSC Community Testing Guidelines.
  • Integration tests updated (where possible). See DSC Community Testing Guidelines.
  • Code changes adheres to DSC Community Style Guidelines.

This change is Reviewable

@codecov
Copy link

codecov bot commented Feb 11, 2021

Codecov Report

Merging #1689 (c250c97) into main (f7676b0) will increase coverage by 0%.
The diff coverage is 100%.

Impacted file tree graph

@@         Coverage Diff          @@
##           main   #1689   +/-   ##
====================================
  Coverage    97%     97%           
====================================
  Files        38      38           
  Lines      6268    6276    +8     
====================================
+ Hits       6112    6120    +8     
  Misses      156     156           
Flag Coverage Δ
unit 97% <100%> (+<1%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...SCResources/DSC_SqlTraceFlag/DSC_SqlTraceFlag.psm1 97% <100%> (+<1%) ⬆️

@johlju johlju added the needs review The pull request needs a code review. label Feb 11, 2021
Copy link
Member

@johlju johlju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 10 files at r4, 2 of 2 files at r5.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @Fiander)

@Fiander
Copy link
Contributor Author

Fiander commented Feb 11, 2021

euh?
@johlju why are we waiting on me?

i dont see any action to do?

@johlju
Copy link
Member

johlju commented Feb 11, 2021

@Fiander I was looking if I could rebase this myself. But I couldn't find a easy way :/ thought I spare you the job. 😄 Could you please rebase this PR against main. So that the CHANGELOG.md is correct, currently it proposes to remove a part of the existing CHANGELOG.

@Fiander
Copy link
Contributor Author

Fiander commented Feb 11, 2021

oke, wil do

Copy link
Member

@johlju johlju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r6.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@johlju johlju added ready for merge The pull request was approved by the community and is ready to be merged by a maintainer. and removed needs review The pull request needs a code review. labels Feb 11, 2021
@Fiander
Copy link
Contributor Author

Fiander commented Feb 11, 2021

Damm you are quick :-) did not even have time to give you a heads up

@johlju
Copy link
Member

johlju commented Feb 11, 2021

Haha I was actually in Reviewable and saw it was missing a header, and when I was about to comment on it Reviewable refreshed for the new commit you pushes and the header was there 😂

@johlju
Copy link
Member

johlju commented Feb 11, 2021

Will probably merge tomorrow because I’m probably in bed when the finishes 😃

@Fiander
Copy link
Contributor Author

Fiander commented Feb 11, 2021

😲 you sleep? I don't have time for that.

@johlju johlju merged commit dc4301c into dsccommunity:main Feb 12, 2021
@johlju
Copy link
Member

johlju commented Feb 12, 2021

@Fiander haha I have noticed the mind works better after some sleep 😉

@johlju johlju removed the ready for merge The pull request was approved by the community and is ready to be merged by a maintainer. label Feb 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SqlTraceFlag: Cannot bind argument to parameter 'ReferenceObject' because it is null.
2 participants