Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breaking Change: Fix for issue #1569 Initial version #1632

Closed
wants to merge 4 commits into from
Closed

Breaking Change: Fix for issue #1569 Initial version #1632

wants to merge 4 commits into from

Conversation

Fiander
Copy link
Contributor

@Fiander Fiander commented Nov 21, 2020

Pull Request (PR) description

This Pull Request (PR) fixes the following issues

Task list

  • Added an entry to the change log under the Unreleased section of the
    file CHANGELOG.md. Entry should say what was changed and how that
    affects users (if applicable), and reference the issue being resolved
    (if applicable).
  • Resource documentation updated in the resource's README.md.
  • Resource parameter descriptions updated in schema.mof.
  • Comment-based help updated, including parameter descriptions.
  • Localization strings updated.
  • Examples updated.
  • Unit tests updated. See DSC Community Testing Guidelines.
  • Integration tests updated (where possible). See DSC Community Testing Guidelines.
  • Code changes adheres to DSC Community Style Guidelines.

This change is Reviewable

@codecov
Copy link

codecov bot commented Nov 21, 2020

Codecov Report

Merging #1632 (09e574d) into master (235c064) will increase coverage by 0%.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #1632   +/-   ##
======================================
  Coverage      98%     98%           
======================================
  Files          37      37           
  Lines        6014    6031   +17     
======================================
+ Hits         5925    5942   +17     
  Misses         89      89           
Flag Coverage Δ
unit 98% <100%> (+<1%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...SCResources/DSC_SqlWaitForAG/DSC_SqlWaitForAG.psm1 100% <100%> (ø)

@Fiander Fiander closed this Nov 23, 2020
@Fiander
Copy link
Contributor Author

Fiander commented Nov 23, 2020

branch of pull request gone wrong

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant