Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SqlSetup: Update comment-based help in example #1609

Merged
merged 1 commit into from
Aug 11, 2020
Merged

SqlSetup: Update comment-based help in example #1609

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 11 additions & 6 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,15 +5,14 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

## [Unreleased]

### Added

- SqlDatabaseObjectPermission
- New integration tests to verify scenarios when passing a single permission.

### Changed

- SqlServerDsc
- Minor document changes in the file `build.yml`.
- Document changes in the file `build.yml`.
- The regular expression for `major-version-bump-message` in the file
`GitVersion.yml` was changed to only raise major version when the
commit message contain the phrase `breaking change`, or when it contain
the word `breaking` or `major`.
- SqlSetup
- Duplicate function Get-SqlMajorVersion was removed and instead the
helper function `Get-FilePathMajorVersion` from the helper module
Expand All @@ -35,6 +34,12 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
_DscResource.Common_.
- SqlDatabaseObjectPermission
- Fixed method invocation failed because of missing `Where()` method ([issue #1600](https://github.com/PowerShell/SqlServerDsc/issues/1600)).
- Added new integration tests to verify scenarios when passing a single permission.
- SqlSetup
- The example `4-InstallNamedInstanceInFailoverClusterFirstNode.ps1` was
updated to no longer reference the issue #405 and issue #444 in the
comment-based help. The issues was fixed a while back and _SqlSetup_
now supports the built-in parameter `PsDscRunAsCredential` ([issue #975](https://github.com/PowerShell/SqlServerDsc/issues/975)).

## [14.2.0] - 2020-07-23

Expand Down
3 changes: 0 additions & 3 deletions source/Examples/Resources/SqlSetup/4-InstallNamedInstanceInFailoverClusterFirstNode.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,9 +22,6 @@
The media will be copied locally, using impersonation with the credentials provided in SourceCredential, so
that the impersonated credentials in SetupCredential can access the media locally.

Setup cannot be run using PsDscRunAsCredential at this time (see issue #405 and issue #444). That
also means that at this time PsDscRunAsCredential can not be used to access media on the UNC share.

There is currently a bug that prevents the resource to logon to the instance if the current node is not the
active node. This is because the resource tries to logon using the SYSTEM account instead of the credentials
in SetupCredential, and the resource does not currently support the built-in PsDscRunAsCredential either (see
Expand Down